Skip to content

Commit

Permalink
Merge pull request sylhare#17 from exercism/csharp-fixes
Browse files Browse the repository at this point in the history
csharp: various fixes
  • Loading branch information
robkeim authored Dec 31, 2019
2 parents 6e79f50 + 4c4a2d4 commit 56f7426
Show file tree
Hide file tree
Showing 22 changed files with 15 additions and 45 deletions.
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,27 +47,27 @@ An exercise has the following files. In the browser they will show at the releva

This file provides an introduction to the concept. It should be explicit about what the exercise teaches and maybe provide a brief introduction to the concepts, but not give away so much that the user doesn't have to do any work to solve the exercise.

See the C# floating-point-numbers exercise's [introduction.md file](./languages/csharp/concept-exercises/floating-point-numbers/.docs/introduction.md) for an example.
See the C# floating-point-numbers exercise's [introduction.md file](./languages/csharp/concept-exercises/numbers-floating-point/.docs/introduction.md) for an example.

#### `.docs/instructions.md`

This file provides instructions for the exercise. It should explicitly explain what the user needs to do (define a function with the signature `X.y(...)` that takes an A and returns a Z), and provide at least one example usage of that function. If there are multiple tasks within the exercise, it should provide an example of each.

See the C# floating-point-numbers exercise's [instructions.md file](./languages/csharp/concept-exercises/floating-point-numbers/.docs/instructions.md) for an example.
See the C# floating-point-numbers exercise's [instructions.md file](./languages/csharp/concept-exercises/numbers-floating-point/.docs/instructions.md) for an example.

#### `.docs/hints.md`

If the user gets stuck, we will allow them to click a button requesting a hint, which shows this file. We will softly discourage them using it.

The file should contain both general and task-specific "hints". These hints should be enough to unblock almost any user. They might link to the docs of the functions that need to be used.

See the C# floating-point-numbers exercise's [hints.md file](./languages/csharp/concept-exercises/floating-point-numbers/.docs/hints.md) for an example.
See the C# floating-point-numbers exercise's [hints.md file](./languages/csharp/concept-exercises/numbers-floating-point/.docs/hints.md) for an example.

#### `.docs/after.md`

Once the user completes the exercise they will be shown this file, which gives them any bonus information or further reading about the concept taught.

See the C# floating-point-numbers exercise's [after.md file](./languages/csharp/concept-exercises/floating-point-numbers/.docs/after.md) for an example.
See the C# floating-point-numbers exercise's [after.md file](./languages/csharp/concept-exercises/numbers-floating-point/.docs/after.md) for an example.

## Repository structure

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@
<TargetFramework>netcoreapp3.0</TargetFramework>
</PropertyGroup>

<ItemGroup>
<Compile Remove="Example.cs" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.4.0" />
<PackageReference Include="xunit" Version="2.4.1" />
Expand Down
4 changes: 0 additions & 4 deletions languages/csharp/concept-exercises/dates/Dates.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@
<TargetFramework>netcoreapp3.0</TargetFramework>
</PropertyGroup>

<ItemGroup>
<Compile Remove="Example.cs" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.4.0" />
<PackageReference Include="xunit" Version="2.4.1" />
Expand Down
4 changes: 0 additions & 4 deletions languages/csharp/concept-exercises/enums/Enums.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@
<TargetFramework>netcoreapp3.0</TargetFramework>
</PropertyGroup>

<ItemGroup>
<Compile Remove="Example.cs" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.4.0" />
<PackageReference Include="xunit" Version="2.4.1" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@
<TargetFramework>netcoreapp3.0</TargetFramework>
</PropertyGroup>

<ItemGroup>
<Compile Remove="Example.cs" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.4.0" />
<PackageReference Include="xunit" Version="2.4.1" />
Expand Down
2 changes: 1 addition & 1 deletion languages/csharp/concept-exercises/numbers/Numbers.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ public static double ProductionRatePerHour(int speed)
{
// TODO: implement this method
}

public static int WorkingItemsPerMinute(int speed)
{
// TODO: implement this method
Expand Down
4 changes: 0 additions & 4 deletions languages/csharp/concept-exercises/numbers/Numbers.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@
<TargetFramework>netcoreapp3.0</TargetFramework>
</PropertyGroup>

<ItemGroup>
<Compile Remove="Example.cs" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.4.0" />
<PackageReference Include="xunit" Version="2.4.1" />
Expand Down
4 changes: 0 additions & 4 deletions languages/csharp/concept-exercises/strings/Strings.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@
<TargetFramework>netcoreapp3.0</TargetFramework>
</PropertyGroup>

<ItemGroup>
<Compile Remove="Example.cs" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.4.0" />
<PackageReference Include="xunit" Version="2.4.1" />
Expand Down
26 changes: 10 additions & 16 deletions languages/csharp/config.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,42 +8,36 @@
{
"slug": "strings",
"uuid": "eda235a5-37de-4fb6-a5c5-cf7aa2309987",
"concepts": ["basic-string-methods", "basic-string-formatting"],
"concepts": ["basic-strings"],
"prerequisites": []
},
{
"slug": "floating-point-numbers",
"slug": "numbers-floating-point",
"uuid": "4eb8d86f-7123-473e-9d96-7939e9652608",
"concepts": ["advanced-floating-point-numbers", "loops"],
"concepts": ["floating-point-numbers", "loops"],
"prerequisites": [
"basic-signed-integers",
"basic-floating-point-numbers",
"conditionals",
"type-conversion"
"basic-numbers",
"basic-type-conversion",
"conditionals"
]
},
{
"slug": "numbers",
"uuid": "4eb8d86f-7123-473e-9d96-7939e9652608",
"concepts": [
"basic-signed-integers",
"basic-floating-point-numbers",
"conditionals",
"type-conversion"
],
"concepts": ["basic-numbers", "basic-type-conversion", "conditionals"],
"prerequisites": []
},
{
"slug": "enums",
"uuid": "047b895b-7039-4af6-ad3a-17fd818d0b88",
"concepts": ["basic-enums"],
"prerequisites": ["basic-string-methods", "basic-string-formatting"]
"prerequisites": ["basic-strings"]
},
{
"slug": "dates",
"uuid": "7762d9ec-ca95-4e10-b93c-afd2521787a2",
"concepts": ["basic-dates", "basic-time", "advanced-string-formatting"],
"prerequisites": ["basic-signed-integers", "basic-string-formatting"]
"concepts": ["basic-dates", "basic-time", "string-formatting"],
"prerequisites": ["basic-numbers", "basic-strings"]
},
{
"slug": "bitwise-operations",
Expand Down

0 comments on commit 56f7426

Please sign in to comment.