dns: store transaction in a VecDeque #7300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of a simple Vector. So that, when many old transactions get removed, suricata does not spend much time in moving the contents of the vector, as it removes the transaciton one by one...
|
Closing in favor of Jason ish work to come |
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Nov 27, 2024
In the situation where the mem buffer cannot be expanded to the requested size, log a one time warning per JSON logger with bit of the log message that is being dropped, then return. This also fixes the call to MemBufferExpand which is supposed by passed the amount to expand by, not the new size required. Ticket: OISF#7300
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Nov 27, 2024
In the situation where the mem buffer cannot be expanded to the requested size, drop the log message. For each JSON log context, a warning will be emitted once with a partial bit of the log record being dropped to identify what event types may be leading to large log records. This also fixes the call to MemBufferExpand which is supposed be passed the amount to expand by, not the new size required. Ticket: OISF#7300
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Nov 28, 2024
In the situation where the mem buffer cannot be expanded to the requested size, drop the log message. For each JSON log context, a warning will be emitted once with a partial bit of the log record being dropped to identify what event types may be leading to large log records. This also fixes the call to MemBufferExpand which is supposed be passed the amount to expand by, not the new size required. Ticket: OISF#7300
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Nov 28, 2024
In the situation where the mem buffer cannot be expanded to the requested size, drop the log message. For each JSON log context, a warning will be emitted once with a partial bit of the log record being dropped to identify what event types may be leading to large log records. This also fixes the call to MemBufferExpand which is supposed be passed the amount to expand by, not the new size required. Ticket: OISF#7300
Kotodian
pushed a commit
to QianKaiLin/suricata
that referenced
this pull request
Dec 1, 2024
In the situation where the mem buffer cannot be expanded to the requested size, drop the log message. For each JSON log context, a warning will be emitted once with a partial bit of the log record being dropped to identify what event types may be leading to large log records. This also fixes the call to MemBufferExpand which is supposed be passed the amount to expand by, not the new size required. Ticket: OISF#7300
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Dec 2, 2024
In the situation where the mem buffer cannot be expanded to the requested size, drop the log message. For each JSON log context, a warning will be emitted once with a partial bit of the log record being dropped to identify what event types may be leading to large log records. This also fixes the call to MemBufferExpand which is supposed be passed the amount to expand by, not the new size required. Ticket: OISF#7300 (cherry picked from commit d39e427)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5271
Describe changes:
Replaces #7245 with rebase to get better CI
@jasonish do you want to make something more generic cf https://redmine.openinfosecfoundation.org/issues/5278 ?