Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect/transform: fix leak in xor transform parse #12147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7229 follow up

Describe changes:

  • detect/transform: fix leak in xor transform parse

Fixes: 8984bc6 ("transforms: move xor to rust")

Fixes: 8984bc6 ("transforms: move xor to rust")
@catenacyber
Copy link
Contributor Author

I wonder why oss-fuzz did not catch it

Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.78%. Comparing base (13841c0) to head (c26cb9a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12147   +/-   ##
=======================================
  Coverage   49.77%   49.78%           
=======================================
  Files         909      909           
  Lines      257884   257887    +3     
=======================================
+ Hits       128367   128391   +24     
+ Misses     129517   129496   -21     
Flag Coverage Δ
fuzzcorpus 60.93% <100.00%> (-0.01%) ⬇️
livemode 19.43% <0.00%> (-0.01%) ⬇️
pcap 44.38% <0.00%> (-0.02%) ⬇️
suricata-verify 62.69% <0.00%> (+<0.01%) ⬆️
unittests 8.98% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 23514

@victorjulien victorjulien added this to the 8.0 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants