Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next/645/70x/20241124/v1 #12146

Merged
merged 2 commits into from
Nov 25, 2024
Merged

next/645/70x/20241124/v1 #12146

merged 2 commits into from
Nov 25, 2024

Conversation

victorjulien
Copy link
Member

catenacyber and others added 2 commits November 18, 2024 11:59
@catenacyber
detect/transforms: write directly in inspect buffer
f80ebd5 
instead of writing to a temporary buffer and then copying,
to save the cost of copying.

Ticket: 7229

Not a cherry-pick as we do not put the transforms in rust,
but just do this optimization in C
@jlucovsky @victorjulien
detect/sip.stat_code: Correct sticky buffer name
fccb328 
Issue: 7295

The sticky buffer name was incorrectly set to method; this commit fixes
the name typo with stat_code.
@codecov Codecov
Copy link

codecov bot commented Nov 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 78.72340% with 10 lines in your changes missing coverage. Please review.

Project coverage is 83.13%. Comparing base (c3aa3ae) to head (fccb328).
Report is 2 commits behind head on main-7.0.x.

Additional details and impacted files 
@@              Coverage Diff               @@
##           main-7.0.x   #12146      +/-   ##
==============================================
- Coverage       83.27%   83.13%   -0.15%     
==============================================
  Files             922      922              
  Lines          260794   260821      +27     
==============================================
- Hits           217177   216826     -351     
- Misses          43617    43995     +378
Flag Coverage Δ
fuzzcorpus 64.06% <53.19%> (-0.32%) ⬇️
suricata-verify 63.30% <78.72%> (-0.03%) ⬇️
unittests 62.38% <46.80%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 23505

@victorjulien victorjulien mentioned this pull request Nov 24, 2024
Closed
catenacyber
catenacyber approved these changes Nov 24, 2024
View reviewed changes
Copy link
Contributor

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks consistent with the approved PRs, and had the right SV PR

@victorjulien victorjulien merged commit fccb328 into OISF:main-7.0.x Nov 25, 2024
44 of 45 checks passed
This was referenced Nov 25, 2024
Merged
Closed
@victorjulien victorjulien deleted the next/645/70x/20241124/v1 branch November 25, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catenacyber catenacyber catenacyber approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@victorjulien @suricata-qa @catenacyber @jlucovsky