Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Only run CodeQL python if the PR contains changed files that are python #12144

Conversation

Nancyenos
Copy link
Contributor

@Nancyenos Nancyenos commented Nov 23, 2024

Ticket: #7358

Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.

Contribution style:

Link to ticket: https://redmine.openinfosecfoundation.org/issues/7358

Describe changes:

-Added Conditional CodeQL Python analysis: Run only when PR modifies Python files

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.95%. Comparing base (13841c0) to head (11d870f).

❗ There is a different number of reports uploaded between BASE (13841c0) and HEAD (11d870f). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (13841c0) HEAD (11d870f)
fuzzcorpus 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12144      +/-   ##
==========================================
- Coverage   49.77%   43.95%   -5.83%     
==========================================
  Files         909      909              
  Lines      257884   257845      -39     
==========================================
- Hits       128367   113337   -15030     
- Misses     129517   144508   +14991     
Flag Coverage Δ
fuzzcorpus ?
livemode 19.43% <ø> (+<0.01%) ⬆️
pcap 44.38% <ø> (-0.03%) ⬇️
suricata-verify 62.70% <ø> (+0.01%) ⬆️
unittests 8.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

paths-ignore:
- "doc/**"
paths:
- "**/*.py" # Trigger workflow only if Python files are changed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL CPP should still have been run and it was not, right ?

Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Philippe pointed an issue inline.

@Nancyenos
Copy link
Contributor Author

working on it

@Nancyenos
Copy link
Contributor Author

work continued in #12150

@Nancyenos Nancyenos closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants