RFC - WIP - userguide: explain rule types and categorization - v2 #12105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add documentation about the rule types introduced by 2696fda.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12105 +/- ##
==========================================
+ Coverage 83.23% 83.25% +0.01%
==========================================
Files 906 906
Lines 257647 257647
==========================================
+ Hits 214458 214501 +43
+ Misses 43189 43146 -43
Flags with carried forward coverage won't be shown. Click here to find out more. |
inashivb
reviewed
Nov 8, 2024
|
|
||
| .. container:: example-rule | ||
|
|
||
| alert tcp-pkt any any -> any any (msg:"tcp-pkt, no content"; sid:201;) |
There was a problem hiding this comment.
Love these example rules! <3
Suggestion: Perhaps explicit IP addresses here
There was a problem hiding this comment.
Thanks, most of them are from the SV tests for rule types :D
I'll add a rule with explicit IP addresses, merci!
|
Feedback incorporated in follow up #12107 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation about the rule types introduced by 2696fda.
Previous PR: #12089
Built docs: https://suri-rtd-test.readthedocs.io/en/doc-sigtypes-et-properties-v2/rules/intro.html#rule-s-types-and-categorization
Describe changes:
TODOs: