Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dpdk/hw_offload: add support for vlan stripping - v5 #12016

Closed
wants to merge 1 commit into from

Conversation

adaki4
Copy link

@adaki4 adaki4 commented Oct 23, 2024

Utilize DPDK API for hardware vlan stripping if supported by NIC.

Ticket: 7330

Contribution style:

Our Contribution agreements:

Changes (if applicable):

Previous PR #12014

Describe changes:
v5

  • fix missing semicolons

v4

  • fix wrong return type in ConfigSetVlanStrip

v3

  • minor changes in variable names
  • call SCLogConfig only when VLAN stripping is supported
  • change return type of ConfigSetVlanStrip to void

v2

  • add SCLogWarning, SCLogConfig for setting vlan stripping
  • create function PortConfSetVlanOffload that enables the vlan stripping and logging

v1

  • add option to enable hardware offload / strip of vlan tags with DPDK API on supported NICs
  • option can be enabled in suricata.yaml

Utilize DPDK API for hardware vlan stripping if supported by NIC.

Ticket: 7330
Copy link

NOTE: This PR may contain new authors.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 65.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 83.24%. Comparing base (30806ce) to head (c9dcfe9).
Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12016      +/-   ##
==========================================
+ Coverage   83.22%   83.24%   +0.02%     
==========================================
  Files         910      910              
  Lines      258136   258156      +20     
==========================================
+ Hits       214831   214908      +77     
+ Misses      43305    43248      -57     
Flag Coverage Δ
fuzzcorpus 61.49% <ø> (+0.08%) ⬆️
livemode 19.39% <65.00%> (+<0.01%) ⬆️
pcap 44.46% <ø> (-0.01%) ⬇️
suricata-verify 62.73% <ø> (-0.02%) ⬇️
unittests 59.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@lukashino lukashino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side.

@victorjulien victorjulien added this to the 8.0 milestone Oct 24, 2024
@victorjulien
Copy link
Member

Merged in #12032, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants