Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

userguide: fix integer keyword matches list format - v1 #12012

Closed

Conversation

jufajardini
Copy link
Contributor

List wasn't being properly rendered.

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
none

Describe changes:

  • Fix the formatting so that it actually shows the items like a list.

While checking the documentation, I noticed that what seemed supposed to be a list wasn't being rendered as such (cf https://docs.suricata.io/en/latest/rules/integer-keywords.html#comparison-modes)

List wasn't being properly rendered.
@jufajardini jufajardini added the typo/doc update No code change : only doc or typo fixes label Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.24%. Comparing base (30806ce) to head (3ea10c9).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12012      +/-   ##
==========================================
+ Coverage   83.22%   83.24%   +0.02%     
==========================================
  Files         910      910              
  Lines      258136   258136              
==========================================
+ Hits       214831   214894      +63     
+ Misses      43305    43242      -63     
Flag Coverage Δ
fuzzcorpus 61.49% <ø> (+0.08%) ⬆️
livemode 19.38% <ø> (-0.01%) ⬇️
pcap 44.40% <ø> (-0.07%) ⬇️
suricata-verify 62.74% <ø> (-0.01%) ⬇️
unittests 59.29% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien victorjulien added this to the 8.0 milestone Oct 23, 2024
@victorjulien
Copy link
Member

Merged in #12013, thanks!

@jufajardini jufajardini deleted the minor-fix-int-keyword-matches/v1 branch October 23, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typo/doc update No code change : only doc or typo fixes
Development

Successfully merging this pull request may close these issues.

2 participants