Remove duplicate function declarations-v4 #11998
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
inashivb
reviewed
Oct 22, 2024
There was a problem hiding this comment.
Hi @Nancyenos !
The subject line change is to be done in the commit not the PR title. ;)
Nancyenos
changed the title
Nancyenos
force-pushed
the
Remove-duplicate-function-declarations-v-4
branch
from
26f0fd8
to
aa4523f
Compare
Nancyenos
changed the title
|
@inashivb is it okay now? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11998 +/- ##
==========================================
+ Coverage 82.75% 83.23% +0.48%
==========================================
Files 910 910
Lines 249016 258136 +9120
==========================================
+ Hits 206069 214857 +8788
- Misses 42947 43279 +332
Flags with carried forward coverage won't be shown. Click here to find out more. |
The commit message is good now, thanks (although we prefer not having PRs with force-pushes ;) ) |
2 tasks
|
worked continued in #12015 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #7297
Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Link to ticket: https://redmine.openinfosecfoundation.org/issues/7297
Describe changes:
-Remove duplicate function declarations from header files
-Add a prefix misc: to the subject
-previous pr: #11993