dpdk/hw_offload: add support for vlan stripping - v2 #11997
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Utilize DPDK API for hardware vlan stripping if supported by NIC. Ticket: 7330
|
NOTE: This PR may contain new authors. |
5 tasks
lukashino
reviewed
Oct 21, 2024
| @@ -31,6 +31,7 @@ typedef struct DPDKIfaceConfigAttributes_ { | |||
| const char *checksum_checks; | |||
| const char *checksum_checks_offload; | |||
| const char *mtu; | |||
| const char *vlan_strip_enabled; | |||
There was a problem hiding this comment.
I would suggest this be renamed to the same as the name of the YAML attribute so:
vlan_strip_offload
| const struct rte_eth_dev_info *dev_info, struct rte_eth_conf *port_conf) | ||
| { | ||
| if (iconf->vlan_strip_enabled) { | ||
| SCLogConfig("%s: hardware vlan stripping enabled", iconf->iface); |
There was a problem hiding this comment.
I would only print this in case I actually set the VLAN offload (So a line below L1217)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11997 +/- ##
==========================================
+ Coverage 82.75% 83.22% +0.46%
==========================================
Files 910 910
Lines 249016 258201 +9185
==========================================
+ Hits 206069 214881 +8812
- Misses 42947 43320 +373
Flags with carried forward coverage won't be shown. Click here to find out more. |
3 tasks
|
Continues in 12008 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utilize DPDK API for hardware vlan stripping if supported by NIC.
Ticket: 7330
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
https://redmine.openinfosecfoundation.org/issues/7330
Previous PR #11974
Describe changes:
v2
v1