Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve disableEditing flag #3875

Merged
merged 3 commits into from
Jan 8, 2024

Merge branch 'master' into feat-improve-disable-editing-flag

140f1c6
Select commit
Loading
Failed to load commit list.
Merged

feat: improve disableEditing flag #3875

Merge branch 'master' into feat-improve-disable-editing-flag
140f1c6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 8, 2024 in 0s

44.44% (-1.80%) compared to 8a335bd

View this Pull Request on Codecov

44.44% (-1.80%) compared to 8a335bd

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8a335bd) 46.23% compared to head (140f1c6) 44.44%.
Report is 188 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3875      +/-   ##
==========================================
- Coverage   46.23%   44.44%   -1.80%     
==========================================
  Files          78       80       +2     
  Lines        1276     1332      +56     
  Branches      312      327      +15     
==========================================
+ Hits          590      592       +2     
- Misses        548      587      +39     
- Partials      138      153      +15     
Files Coverage Δ
platform/app/src/routes/WorkList/filtersMeta.js 0.00% <ø> (ø)
platform/core/src/log.js 14.28% <ø> (-85.72%) ⬇️
...ervices/DicomMetadataStore/createSeriesMetadata.js 0.00% <ø> (ø)
...services/DicomMetadataStore/createStudyMetadata.js 0.00% <ø> (ø)
platform/core/src/utils/addAccessors.js 9.09% <ø> (ø)
platform/core/src/utils/downloadCSVReport.js 0.00% <ø> (ø)
platform/core/src/utils/formatDate.js 0.00% <ø> (ø)
platform/core/src/utils/index.js 100.00% <ø> (ø)
...form/core/src/utils/isDisplaySetReconstructable.js 5.00% <ø> (+0.18%) ⬆️
...ils/metadataProvider/getPixelSpacingInformation.js 0.00% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d56070...140f1c6. Read the comment docs.