Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(HPService): custom image load performed is now reset to false on HP exit #3809

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Fix(HPService): custom image load performed is now reset to false on HP exit #3809

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce21315
reset custom image load performed on HP exit
salimkanoun Nov 26, 2023
842e532
comments
salimkanoun Nov 26, 2023
da02d5a
Merge branch 'master' into fix-run-costum-image-load-strategy-when-op…
salimkanoun Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion platform/core/src/services/HangingProtocolService/HangingProtocolService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ export default class HangingProtocolService extends PubSubService {
*
* @returns A boolean indicating whether a custom image load has been performed or not.
*/
public getCustomImageLoadPerformed(): boolean {
private getCustomImageLoadPerformed(): boolean {
return this.customImageLoadPerformed;
}

Expand Down Expand Up @@ -957,6 +957,8 @@ export default class HangingProtocolService extends PubSubService {
try {
if (!this.protocol || this.protocol.id !== protocol.id) {
this.stageIndex = options?.stageIndex || 0;
//Reset load performed to false to re-fire loading strategy at new study opening
this.customImageLoadPerformed = false;
this._originalProtocol = this._copyProtocol(protocol);

// before reassigning the protocol, we need to check if there is a callback
Expand Down