Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PT Metadata): Allow for PatientWeight to be missing from the metadata #3621

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

jbocce
Copy link
Collaborator

@jbocce jbocce commented Aug 28, 2023

Context

PR to address OHIF #3411

Changes & Results

Allow for PatientWeight to be missing from the metadata
for a PT series - instead of throwing an exception, simply log a warning. Fixes OHIF issue 3411.

Testing

Follow the steps in OHIF #3411

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS: Windows 11
  • Node version: 16.14.0
  • Browser: Chrome 116.0.5845.111

…data

for a PT series - instead of throwing an exception, simply log a warning.
Fixes OHIF issue 3411.
@netlify
Copy link

netlify bot commented Aug 28, 2023

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 97cce8e
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/64ecf9aacc1d970008d2900e
😎 Deploy Preview https://deploy-preview-3621--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 28, 2023

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 97cce8e
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/64ecf9aa1ba81f000860969d
😎 Deploy Preview https://deploy-preview-3621--ohif-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jbocce jbocce requested a review from sedghi August 28, 2023 19:47
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #3621 (97cce8e) into master (a336992) will not change coverage.
Report is 2 commits behind head on master.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3621   +/-   ##
=======================================
  Coverage   42.58%   42.58%           
=======================================
  Files          80       80           
  Lines        1463     1463           
  Branches      340      340           
=======================================
  Hits          623      623           
  Misses        675      675           
  Partials      165      165           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fbdf37...97cce8e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants