-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(handler): Add handler for unsupported sopclassUIDs #3601
feat(handler): Add handler for unsupported sopclassUIDs #3601
Conversation
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## master #3601 +/- ##
=======================================
Coverage 42.58% 42.58%
=======================================
Files 80 80
Lines 1463 1463
Branches 340 340
=======================================
Hits 623 623
Misses 675 675
Partials 165 165 Continue to review full report in Codecov by Sentry.
|
platform/ui/src/components/DisplaySetMessageListTooltip/DisplaySetMessageListTooltip.tsx
Outdated
Show resolved
Hide resolved
platform/core/src/services/HangingProtocolService/HangingProtocolService.ts
Outdated
Show resolved
Hide resolved
platform/core/src/services/DisplaySetService/DisplaySetService.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my comment. Also the PR description would benefit from some screenshots
Code refactored |
platform/core/src/services/DisplaySetService/DisplaySetService.ts
Outdated
Show resolved
Hide resolved
platform/core/src/services/DisplaySetService/DisplaySetService.ts
Outdated
Show resolved
Hide resolved
platform/core/src/services/HangingProtocolService/HangingProtocolService.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my comments, thanks for the update
Added changes required |
...ions/measurement-tracking/src/panels/PanelStudyBrowserTracking/PanelStudyBrowserTracking.tsx
Show resolved
Hide resolved
Probably you forgot to set supportsWildcard: false. In IDC server if you don't set it that happens |
I guess that should be part of the testing section .... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolved the conflict in hangingprotocol.ts file |
Context
Today the default OHIF's behaviour is to filter all unsupported SOPClassUIDs when opening a study. This behaviour is bad if the user wants to chekc if a particular series, not supported by OHIF, reaches the image server. This PR adds a new handler for all unsupported dicom series, adding a displaySet with an attribute, unsupported, that flags the displaySet cannot be used for viewer in OHIF. This PR is related to isssue #3362.
Changes & Results
For each unsupported series, a ThumbnailNoImage will appear with a warning icon, indicating that the particular series is unsupported and should not be used for viewing.
Testing
To test, one should alter the default.js to point to IDC test dataset and use one of the following links:
http://localhost:3000/viewer?StudyInstanceUIDs=1.3.6.1.4.1.14519.5.2.1.308250233404174127024116250321380712318
http://localhost:3000/viewer?StudyInstanceUIDs=1.3.6.1.4.1.14519.5.2.1.111778973144870709834087260276851352536
http://localhost:3000/viewer?StudyInstanceUIDs=1.3.6.1.4.1.14519.5.2.1.2103.7010.237254940005841719629537222159
http://localhost:3000/viewer?StudyInstanceUIDs=1.3.6.1.4.1.14519.5.2.1.122805535915539618236860659468790107523
http://localhost:3000/viewer?StudyInstanceUIDs=1.3.6.1.4.1.14519.5.2.1.340031522181513869336683393500230688871
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment