Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Docker): Fix ARM64 Docker builds by adding node-gyp dependencies (#3595) #3596

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

pdlloyd
Copy link
Contributor

@pdlloyd pdlloyd commented Aug 11, 2023

Context

Fixes #3595: [Bug] Docker build fails on ARM_64 (aarch64v8)

Changes & Results

Adds python3 and build-essential (dpkg-dev, g++, gcc, libc-dev, and make) to the Docker builder image which are dependencies of node-gyp in order to build @parcel/watcher for aarch64v8.

After the addition of these packages, the build completes successfully.

Testing

  1. Run an ARM_64 (aarch64v8) machine (e.g. on AWS) and install Git and Docker.
  2. git clone --recursive https://github.com/OHIF/Viewers.git
  3. cd Viewers
  4. sudo docker build . -t ohif-viewer-image

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS: Ubuntu Linux 22.04.3 LTS
  • Node version: node:16.15.0-slim (Docker image)
  • Browser: Any

@netlify
Copy link

netlify bot commented Aug 11, 2023

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit b5b0435
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/64d70ab0a6b3810008a0ad34
😎 Deploy Preview https://deploy-preview-3596--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 11, 2023

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit b5b0435
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/64d70ab0d6ea500008074a1a
😎 Deploy Preview https://deploy-preview-3596--ohif-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #3596 (b5b0435) into master (5302e5b) will not change coverage.
Report is 2 commits behind head on master.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3596   +/-   ##
=======================================
  Coverage   42.58%   42.58%           
=======================================
  Files          80       80           
  Lines        1463     1463           
  Branches      340      340           
=======================================
  Hits          623      623           
  Misses        675      675           
  Partials      165      165           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88ef7b7...b5b0435. Read the comment docs.

@sedghi
Copy link
Member

sedghi commented Aug 14, 2023

Looks great. This is a great contribution, thanks a lot!

@sedghi sedghi merged commit 41dc424 into OHIF:master Aug 14, 2023
@pdlloyd pdlloyd deleted the issue-3595 branch August 14, 2023 22:33
@pdlloyd
Copy link
Contributor Author

pdlloyd commented Aug 14, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Docker build fails on ARM_64 (aarch64v8)
2 participants