feat(thumbnail highlight): Thumbnails of hydrated series are now highlighted #3594

jbocce · 2023-08-10T20:11:36Z

Context

Thumbnails representing hydratable series (i.e. SR, SEG, RTSTRUCT, etc.) are now highlighted to indicate when the item is hydrated in OHIF.
Addresses OHIF issue #3421.
Also, thumbnails with no image that are 'active' (i.e. the viewport is selected in the viewer) are now also highlighted appropriately with a border just like the image thumbnails.
The highlighting is per as described here

Changes & Results

SEG and RTSTRUCT display sets now have their isHydrated flag set to true when they are hydrated. Hydrated SR display sets for tracked measurements already had this flag set appropriately.

The ThumbnailNoImage modality label colours and the "list-bullets" icon color when the thumbnail is hydrated are now set based on whether the associated display set is hydrated or not. Also a change was made in ThumbnailNoImage so that it indicates an active series (i.e. when visible and highlighted in an OHIF viewport) with a border just like the Thumbnail (with an image).

Testing

A few test cases to consider...

Test A

View a study with tracked measurements.
Double click or drag and drop the SR into a viewport.
Opt NOT to track the measurements and simply view the SR in the viewport.
The thumbnail for the SR should have a border indicating that it is the active viewport. Activating a different viewport should remove the border around the thumbnail.
Similar behaviour should occur when loading a study with SEG or RTSTRUCT and opting NOT to hydrate the segmentation.

Test B

View a study with tracked measurements.
Double click or drag and drop the SR into a viewport.
Opt to track the measurements.
The thumbnail for the hydrated SR should look similar to below...
Similar behaviour should occur when loading a study with SEG or RTSTRUCT after opting to hydrate the segmentation.

Checklist

PR

My Pull Request title is descriptive, accurate and follows the
semantic-release format and guidelines.

Code

My code has been well-documented (function documentation, inline comments,
etc.)

Public Documentation Updates

The documentation page has been updated as necessary for any public API
additions or removals.

Tested Environment

OS: Windows 11
Node version: 16.14.0
Browser: Chrome 115.0.5790.171

…(i.e. SR, SEG, RTSTRUCT, etc.) are now highlighted to indicate when the item is hydrated in OHIF. Addresses OHIF issue 3421. Also, thumbnails with no image that are 'active' (i.e. the viewport is selected in the viewer) are now also highlighted appropriately with a border just like the image thumbnails.

netlify · 2023-08-10T20:11:42Z

✅ Deploy Preview for ohif-dev ready!

Name	Link
🔨 Latest commit	`5bef6ce`
🔍 Latest deploy log	https://app.netlify.com/sites/ohif-dev/deploys/64dcfab7df195400081bb3ec
😎 Deploy Preview	https://deploy-preview-3594--ohif-dev.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2023-08-10T20:11:45Z

✅ Deploy Preview for ohif-platform-docs ready!

Name	Link
🔨 Latest commit	`5bef6ce`
🔍 Latest deploy log	https://app.netlify.com/sites/ohif-platform-docs/deploys/64dcfab7db8ad30007e3908a
😎 Deploy Preview	https://deploy-preview-3594--ohif-platform-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov · 2023-08-10T20:16:05Z

Codecov Report

Merging #3594 (5bef6ce) into master (f845f87) will not change coverage.
Report is 2 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3594   +/-   ##
=======================================
  Coverage   42.58%   42.58%           
=======================================
  Files          80       80           
  Lines        1463     1463           
  Branches      340      340           
=======================================
  Hits          623      623           
  Misses        675      675           
  Partials      165      165

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fe6766...5bef6ce. Read the comment docs.

sedghi

So something came to my mind to try again and seems to be a bug. it is where a segment is hydrated then removed, it still shows it as hydrated

jbocce · 2023-08-11T12:51:26Z

So something came to my mind to try again and seems to be a bug. it is where a segment is hydrated then removed, it still shows it as hydrated

Good catch. I will have a look. Thanks so much.

Moved the setting of the displaySet.isHydrated flag to the SegmentationService. The DisplaySetService event is fired when the isHydrated flag is updated.

jbocce · 2023-08-11T14:22:04Z

extensions/cornerstone/src/services/SegmentationService/SegmentationService.ts

+    } = this.servicesManager.services;
+    const displaySet = displaySetService.getDisplaySetByUID(displaySetUID);
+    displaySet.isHydrated = isHydrated;
+    displaySetService.setDisplaySetMetadataInvalidated(displaySetUID);


Not sure if this is the best way, but at the very least it will start a discussion.

hmmm, I see why you need this, but at the same time we have another listener for this at the OHIFCornerstoneViewport which invalidates the data. Maybe we need another event to decouple this?

How about a new DisplaySetService event called DISPLAY_SET_UPDATED?

I'm not sure really, it is kind of the same event we are invalidating a metadata, but at the same time we don't want to hit that other listener in the OHIFCornerstoneViewport, aaaaah
I hate having DISPLAY_SET_UPDATED and DISPLAY_SET_SERIES_METADATA_INVALIDATED
Let's think till we meet

…possible-to-know-series-hydrated

sedghi · 2023-08-15T14:12:24Z

platform/ui/src/components/ThumbnailList/ThumbnailList.tsx

@@ -36,6 +36,7 @@ const ThumbnailList = ({
          imageSrc,
          messages,
          imageAltText,
+          isHydrated,


it is kind of weird that we have isHydrated even for regular imagees (e.g., CT, PT, etc.), can we rename it to something else? I don't know what but basically it is is this display set hydrated given that it is derived (rt, seg, sr)

How about calling it isADerivedAndHydratedDisplaySet?

How about isHydratedForDerivedDisplaySet

sedghi · 2023-08-15T14:17:43Z

...ions/measurement-tracking/src/panels/PanelStudyBrowserTracking/PanelStudyBrowserTracking.tsx

@@ -248,9 +248,29 @@ function PanelStudyBrowserTracking({
      }
    );

+    const SubscriptionDisplaySetMetaDataInvalidated = displaySetService.subscribe(
+      displaySetService.EVENTS.DISPLAY_SET_SERIES_METADATA_INVALIDATED,


we should add the same logic to the PanelStudyBrowswer too

sedghi

see my comments

sedghi

Looks great. thanks a lot!

…possible-to-know-series-hydrated

igoroctaviano · 2023-09-08T19:04:22Z

@fedorov with this change, do you think we could close #3421?

jbocce requested a review from sedghi August 10, 2023 20:11

sedghi approved these changes Aug 11, 2023

View reviewed changes

sedghi requested changes Aug 11, 2023

View reviewed changes

Updating thumbnails when a segmentation is deleted.

31ac98d

Moved the setting of the displaySet.isHydrated flag to the SegmentationService. The DisplaySetService event is fired when the isHydrated flag is updated.

jbocce commented Aug 11, 2023

View reviewed changes

Merge remote-tracking branch 'upstream/master' into feat/OHIF-3421-im…

404d0b5

…possible-to-know-series-hydrated

sedghi reviewed Aug 15, 2023

View reviewed changes

jbocce added 2 commits August 15, 2023 16:20

PR feedback.

91315a5

git add DisplaySet.ts

84830f3

jbocce requested a review from sedghi August 16, 2023 13:37

sedghi approved these changes Aug 16, 2023

View reviewed changes

Merge remote-tracking branch 'upstream/master' into feat/OHIF-3421-im…

5bef6ce

…possible-to-know-series-hydrated

sedghi merged commit 0f9b369 into OHIF:master Aug 16, 2023

jbocce mentioned this pull request Sep 8, 2023

[Feature Request] v3: impossible to know which of the segmentation series is being displayed #3421

Closed

sedghi mentioned this pull request Sep 26, 2023

release candidate 3p7 RC1 #3680

Closed

This was referenced Oct 10, 2023

candidate 3p7 rc 2 #3712

Closed

feat(v3p7): segmentation mode and cloud server configuration #3717

Closed

feat(v3p7): segmentation mode and cloud server configuration #3718

Closed

feat(v3p7): segmentation mode and cloud server configuration #3720

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(thumbnail highlight): Thumbnails of hydrated series are now highlighted #3594

feat(thumbnail highlight): Thumbnails of hydrated series are now highlighted #3594

jbocce commented Aug 10, 2023

netlify bot commented Aug 10, 2023 •

edited

Loading

netlify bot commented Aug 10, 2023 •

edited

Loading

codecov bot commented Aug 10, 2023 •

edited

Loading

sedghi left a comment •

edited

Loading

jbocce commented Aug 11, 2023

jbocce Aug 11, 2023

sedghi Aug 15, 2023

jbocce Aug 15, 2023

sedghi Aug 15, 2023

sedghi Aug 15, 2023

jbocce Aug 15, 2023

sedghi Aug 15, 2023

sedghi Aug 15, 2023

sedghi left a comment

sedghi left a comment

igoroctaviano commented Sep 8, 2023

feat(thumbnail highlight): Thumbnails of hydrated series are now highlighted #3594

feat(thumbnail highlight): Thumbnails of hydrated series are now highlighted #3594

Conversation

jbocce commented Aug 10, 2023

Context

Changes & Results

Testing

Checklist

PR

Code

Public Documentation Updates

Tested Environment

netlify bot commented Aug 10, 2023 • edited Loading

✅ Deploy Preview for ohif-dev ready!

netlify bot commented Aug 10, 2023 • edited Loading

✅ Deploy Preview for ohif-platform-docs ready!

codecov bot commented Aug 10, 2023 • edited Loading

Codecov Report

sedghi left a comment • edited Loading

Choose a reason for hiding this comment

jbocce commented Aug 11, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sedghi left a comment

Choose a reason for hiding this comment

sedghi left a comment

Choose a reason for hiding this comment

igoroctaviano commented Sep 8, 2023

netlify bot commented Aug 10, 2023 •

edited

Loading

netlify bot commented Aug 10, 2023 •

edited

Loading

codecov bot commented Aug 10, 2023 •

edited

Loading

sedghi left a comment •

edited

Loading