dev(yarn link): make it possible to yarn link easily with cornerstone3D and update docs #3563
Conversation
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sedghi
changed the title
| @@ -186,8 +186,6 @@ module.exports = (env, argv) => { | |||
| chunkFilename: '[id].css', | |||
| }) | |||
| ); | |||
| } else { | |||
There was a problem hiding this comment.
We just don't need this any longer?
There was a problem hiding this comment.
it was giving warning that is injected by deafult
Codecov Report
@@ Coverage Diff @@
## master #3563 +/- ##
=======================================
Coverage 42.93% 42.93%
=======================================
Files 80 80
Lines 1444 1444
Branches 338 338
=======================================
Hits 620 620
Misses 661 661
Partials 163 163 Continue to review full report in Codecov by Sentry.
|
Passing run #3394 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
Context & Changes & Results
We had to do some hacks to be able to yarn link cornersteon3D, but with the new
source-map-loaderit is possible to easily do it.New doc and video also added for yarn link https://vimeo.com/849096279?share=copy
Also old videos were moved between accounts
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment