Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): remove undefined values in combineFrameInstance #3513

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Jul 3, 2023

Fixes #3488

This commit removes any undefined values from the resulting array when combining frame and instance in the combineFrameInstance function in the utils module.

Context

This Pull Request is intended to resolve an issue with the combineFrameInstance function in the utils module of the OHIF Viewers project. Specifically, the function was previously including undefined values in the resulting array when combining frame and instance

Changes & Results

The effect of this change will be a cleaner output from the combineFrameInstance function, with no undefined values present in the resulting array.

Testing

Try the issue above and the provided dicom with this change

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

This commit removes any undefined values from the resulting array when combining frame and instance in the `combineFrameInstance` function in the `utils` module.
@netlify
Copy link

netlify bot commented Jul 3, 2023

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit e667d59
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/64a2f23faa71eb0008ed9397
😎 Deploy Preview https://deploy-preview-3513--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 3, 2023

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit e667d59
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/64a2f23f154f4a0008ed51f7
😎 Deploy Preview https://deploy-preview-3513--ohif-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #3513 (e667d59) into master (e653961) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3513   +/-   ##
=======================================
  Coverage   42.81%   42.81%           
=======================================
  Files          82       82           
  Lines        1448     1448           
  Branches      338      338           
=======================================
  Hits          620      620           
  Misses        665      665           
  Partials      163      163           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d4dd45...e667d59. Read the comment docs.

@cypress
Copy link

cypress bot commented Jul 3, 2023

Passing run #3338 ↗︎

0 36 0 0 Flakiness 0

Details:

fix(utils): remove undefined values in combineFrameInstance
Project: Viewers Commit: e667d59cad
Status: Passed Duration: 03:33 💡
Started: Jul 3, 2023 4:10 PM Ended: Jul 3, 2023 4:14 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@sedghi sedghi requested a review from jbocce July 3, 2023 16:16
Copy link
Collaborator

@jbocce jbocce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I viewed the one sample provided and it looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] MultiFrame DICOM Problem
2 participants