-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(utils): remove undefined values in combineFrameInstance #3513
Conversation
This commit removes any undefined values from the resulting array when combining frame and instance in the `combineFrameInstance` function in the `utils` module.
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## master #3513 +/- ##
=======================================
Coverage 42.81% 42.81%
=======================================
Files 82 82
Lines 1448 1448
Branches 338 338
=======================================
Hits 620 620
Misses 665 665
Partials 163 163 Continue to review full report in Codecov by Sentry.
|
Passing run #3338 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I viewed the one sample provided and it looks good.
Fixes #3488
This commit removes any undefined values from the resulting array when combining frame and instance in the
combineFrameInstance
function in theutils
module.Context
This Pull Request is intended to resolve an issue with the combineFrameInstance function in the utils module of the OHIF Viewers project. Specifically, the function was previously including undefined values in the resulting array when combining frame and instance
Changes & Results
The effect of this change will be a cleaner output from the combineFrameInstance function, with no undefined values present in the resulting array.
Testing
Try the issue above and the provided dicom with this change
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment