Address SliceThickness.toFixed TypeError #3510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## master #3510 +/- ##
=======================================
Coverage 42.81% 42.81%
=======================================
Files 82 82
Lines 1448 1448
Branches 338 338
=======================================
Hits 620 620
Misses 665 665
Partials 163 163 Continue to review full report in Codecov by Sentry.
|
sedghi
approved these changes
Jul 3, 2023
|
Thanks a lot! |
This was referenced Oct 10, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes Issue 3465. This error resulted from the
SliceThicknessvariable inextensions/cornerstone-dicom-seg/src/viewports/OHIFCornerstoneSEGViewport.tsxhaving a string value and being unable to call toFixed.Changes & Results
I added
parseFloatto a couple of lines inextensions/cornerstone-dicom-seg/src/viewports/OHIFCornerstoneSEGViewport.tsxand it seems to have fixed the problem I was having before and renders segmentations. These are my changes (starting at line 346):... thickness: SliceThickness ? `${parseFloat(SliceThickness).toFixed(2)}mm` : '', spacing: SpacingBetweenSlices !== undefined ? `${parseFloat(SpacingBetweenSlices).toFixed(2)}mm` : '', ...Before adding these changes, I was faced with a 'Something Went Wrong' warning screen as depicted in Issue 3465. After applying them, I was successfully able to view segmentations, as shown here:
Testing
To test my changes, use OHIF in combination with a DCM4CHEE archive. Select a SEG/MR study from the main page and launch the basic viewer. Click on the segmentation to open it. It should now be visible even in cases where SliceThickness has a string value.
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment