-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed Fusion_Viewport to allow displaySets to be changed #3502
Conversation
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## master #3502 +/- ##
=======================================
Coverage 42.81% 42.81%
=======================================
Files 82 82
Lines 1448 1448
Branches 338 338
=======================================
Hits 620 620
Misses 665 665
Partials 163 163 Continue to review full report in Codecov by Sentry.
|
Could you enable the series tray, but closed by default? That way we can test this. Also update the branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, marked the wrong issue. Would like to see this with the series tray enabled but closed.
Dan approved this with it closed.
@wayfarer3130 he add the panel but the deploy preview is in a cancelled state, however it's workin locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now - tested locally and it runs fine.
Context
This pull request addresses an issue where the fusion viewport does not refresh and match correctly when dragging and dropping CT and PT displaySets. The problem arises because the volumes added do not share the same FrameOfReferenceUID. Additionally, the displaySetMatchDetail of the fusion viewport is not updated with the new displaySetInstanceUID, further exacerbating the issue.
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment