feat(InputNumber): adding label element in InputNumber Component and … #3501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-dev canceled.
|
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## master #3501 +/- ##
=======================================
Coverage 38.27% 38.27%
=======================================
Files 82 82
Lines 1348 1348
Branches 303 303
=======================================
Hits 516 516
Misses 666 666
Partials 166 166 Continue to review full report in Codecov by Sentry.
|
|
Could we please have some images showing what this looks like? |
|
here it is |
sedghi
reviewed
Jul 3, 2023
| @@ -14,6 +15,7 @@ import './InputNumber.css'; | |||
|
|
|||
| const sizesClasses = { | |||
| sm: 'w-[45px] h-[28px]', | |||
| bg: 'w-[206px] h-[35px]', | |||
There was a problem hiding this comment.
if by bg you mean big? I prefer lg to be more consistent with the rest of the code
|
can you fix the CI error? |
it seems ok, it just a network issue |
sedghi
reviewed
Jul 7, 2023
| @@ -76,6 +82,8 @@ const InputNumber: React.FC<{ | |||
| ); | |||
|
|
|||
| return ( | |||
| <div className={'flex flex-col flex-1'}> | |||
| <Label className={labelClassName} text={label}></Label> | |||
There was a problem hiding this comment.
this should have a gaurd for the label
label &&
sedghi
approved these changes
Jul 7, 2023
This was referenced Oct 10, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…export it
Context
Export the InputNumber component and adding a l label
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment