Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DICOM Upload): use correct Accept header for upload #3498

Merged

Conversation

jbocce
Copy link
Collaborator

@jbocce jbocce commented Jun 27, 2023

Context

See #3497.

Changes & Results

For DICOM store, the response will not be DICOM, so do not set the Accept header to be what would be otherwise used for retrieve/query.

Testing

See #3497 for how to test/verify that the issue is fixed.
Ensure that store/upload for other data sources (e.g. Orthanc) works properly.

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS: Windows 11
  • Node version: 16.14.0
  • Browser: Chrome 114.0.5735.134

@netlify
Copy link

netlify bot commented Jun 27, 2023

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit bb7a7e2
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/649afee6907ba10008c4e0df
😎 Deploy Preview https://deploy-preview-3498--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jun 27, 2023

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit bb7a7e2
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/649afee68a25940008f59880
😎 Deploy Preview https://deploy-preview-3498--ohif-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jbocce jbocce requested review from wayfarer3130 and sedghi June 27, 2023 15:23
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #3498 (bb7a7e2) into master (52f419d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3498   +/-   ##
=======================================
  Coverage   38.27%   38.27%           
=======================================
  Files          82       82           
  Lines        1348     1348           
  Branches      303      303           
=======================================
  Hits          516      516           
  Misses        666      666           
  Partials      166      166           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c98211c...bb7a7e2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants