Make ContourImageSequence check under ROIContourSequence->ContourImageSequence optional #3476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-remove imageId check as ContourImageSequence checked is optional
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## master #3476 +/- ##
=======================================
Coverage 38.27% 38.27%
=======================================
Files 82 82
Lines 1348 1348
Branches 303 303
=======================================
Hits 516 516
Misses 666 666
Partials 166 166 Continue to review full report in Codecov by Sentry.
|
dxlin
changed the title
This was referenced Oct 10, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-add try/catch to geometry loader to prevent single error from hanging load
-remove imageId check as ContourImageSequence checked is optional
Context
Try/Catch:
Error in any rt struct segment will stop (hang) all segments from loading.
ContourImageSequence:
Current imageId check is checking for an optional field, causes valid dicomRTs from failing to load.
Current ContourImageSequence check is on:
https://dicom.innolitics.com/ciods/rt-structure-set/roi-contour/30060039/30060040/30060016
There is however a mandatory ContourImageSequence, but should not be checked here:
https://dicom.innolitics.com/ciods/rt-dose/structure-set/30060010/30060012/30060014/30060016
Changes & Results
-add try/catch to geometryLoader segment to prevent error from hanging entire load process
-remove ContourImageSequence->imageId check during loadRTStruct
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment