Colormap wasn't being applied #3464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wayfarer3130
changed the title
wayfarer3130
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3464 +/- ##
=======================================
Coverage 42.81% 42.81%
=======================================
Files 82 82
Lines 1448 1448
Branches 338 338
=======================================
Hits 620 620
Misses 665 665
Partials 163 163
Continue to review full report in Codecov by Sentry.
|
wayfarer3130
changed the title
wayfarer3130
commented
Jun 29, 2023
wayfarer3130
commented
Jun 29, 2023
| @@ -36,13 +35,6 @@ function _createColormap(label, colormap) { | |||
| colormap, | |||
| }, | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Duplicated unnecessarily redundant.
wayfarer3130
commented
Jun 29, 2023
| @@ -345,7 +338,6 @@ const toolbarButtons = [ | |||
| tooltip: 'PET Image Colormap', | |||
| }, | |||
| isAction: true, // ? | |||
| renderer: WindowLevelMenuItem, | |||
There was a problem hiding this comment.
This was causing the menu to have numbers beside it, causing it to look like it was appliable from the keyboard.
Passing run #3343 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
wayfarer3130
commented
Jun 29, 2023
jbocce
reviewed
Jun 29, 2023
jbocce
approved these changes
Jul 4, 2023
This was referenced Oct 10, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixed the calls to set the PET colormaps to use the new format/correct set of values to be looked up.
Changes & Results
Colormaps can now be applied by selecting the menu item. Test changing the colormaps.
Removed the number from the colormap menu, using the default renderer so it shows correctly
Removed keyboard shortcuts 6-9 as they were causing exceptions due to invalid values
OpacityMapping is renamed to opacity since the API has changed in cornerstone3D
Testing
Run tmtv mode, change the colormap.
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment