Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined volumes in customizable viewport overlay #3435

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

Sofien-Sellami
Copy link
Contributor

Context

Fixing undefined volumes in _getViewportInstance function

Changes & Results

Testing

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS:
  • Node version:
  • Browser:

@netlify
Copy link

netlify bot commented Jun 2, 2023

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit d3dc760
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/64885e4a80c2160008c4ab1e
😎 Deploy Preview https://deploy-preview-3435--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #3435 (d3dc760) into master (cadb559) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3435   +/-   ##
=======================================
  Coverage   38.27%   38.27%           
=======================================
  Files          82       82           
  Lines        1348     1348           
  Branches      303      303           
=======================================
  Hits          516      516           
  Misses        666      666           
  Partials      166      166           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6d967a...d3dc760. Read the comment docs.

@Sofien-Sellami Sofien-Sellami changed the title Fix undefined volumes Fix undefined volumes in customizable viewport overlay Jun 2, 2023
@salimkanoun
Copy link
Contributor

I guess this one is for @sedghi, a simple fix for overlay that has a key error to retrieve data to display

@netlify
Copy link

netlify bot commented Jun 13, 2023

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit d3dc760
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/64885e4a35489100077cb53b
😎 Deploy Preview https://deploy-preview-3435--ohif-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants