-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added 16bit config flags #3292
Conversation
✅ Deploy Preview for ohif-platform-viewer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for ohif-platform-docs canceled.
|
Codecov Report
@@ Coverage Diff @@
## v3-stable #3292 +/- ##
==============================================
+ Coverage 25.15% 37.80% +12.64%
==============================================
Files 119 85 -34
Lines 2862 1386 -1476
Branches 555 305 -250
==============================================
- Hits 720 524 -196
+ Misses 1856 695 -1161
+ Partials 286 167 -119 see 76 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@@ -0,0 +1,189 @@ | |||
window.config = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we not call this default for now? maybe say experimental_16bit
@@ -39,11 +40,27 @@ export default async function init({ | |||
configuration, | |||
appConfig, | |||
}: Types.Extensions.ExtensionParams): Promise<void> { | |||
await cs3DInit(); | |||
await cs3DInit({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you pull new changes? I added some modification to cs3DInit recently, and it makes sense to merge those changes here as well
@Ouwen Also for this one, any one free you have to work on this? |
merged this in another PR |
Context
This adds flags to enable 16 bit texture rendering with preferSizeOverAccuracy always being true if 16bit rendering is enabled.
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment