Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): add German translations #2741

Closed
wants to merge 2 commits into from
Closed

Conversation

pwespi
Copy link
Contributor

@pwespi pwespi commented Mar 11, 2022

PR Checklist

  • Brief description of changes
  • Links to any relevant issues
  • Required status checks are passing
  • User cases if changes impact the user's experience
  • @mention a maintainer to request a review
  • add German translations

@netlify
Copy link

netlify bot commented Mar 11, 2022

Deploy Preview for ohif-platform-docs canceled.

Name Link
🔨 Latest commit 3c5d974
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/62e2b168d1c03300089d8e24

@netlify
Copy link

netlify bot commented Mar 11, 2022

Deploy Preview for ohif-platform-viewer ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-viewer/deploys/62e2ddd21d7ee31e1303abf9
😎 Deploy Preview https://deploy-preview-2741--ohif-platform-viewer.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #2741 (3c5d974) into v3-stable (9f1e813) will increase coverage by 5.72%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           v3-stable    #2741      +/-   ##
=============================================
+ Coverage      25.15%   30.88%   +5.72%     
=============================================
  Files            119      103      -16     
  Lines           2862     2270     -592     
  Branches         555      447     -108     
=============================================
- Hits             720      701      -19     
+ Misses          1856     1289     -567     
+ Partials         286      280       -6     
Impacted Files Coverage Δ
...tform/core/src/services/CineService/CineService.js 12.50% <0.00%> (-6.25%) ⬇️
.../services/HangingProtocolService/ProtocolEngine.js 0.00% <0.00%> (-2.18%) ⬇️
.../services/MeasurementService/MeasurementService.js 47.23% <0.00%> (-1.96%) ⬇️
platform/core/src/classes/CommandsManager.js 90.69% <0.00%> (-1.14%) ⬇️
...e/src/services/HangingProtocolService/HPMatcher.js 6.89% <0.00%> (-0.80%) ⬇️
...s/HangingProtocolService/HangingProtocolService.js 0.63% <0.00%> (-0.76%) ⬇️
platform/core/src/classes/MetadataProvider.js 4.72% <0.00%> (-0.54%) ⬇️
...core/src/services/ToolBarService/ToolBarService.js 1.36% <0.00%> (-0.13%) ⬇️
platform/viewer/src/index.js 0.00% <0.00%> (ø)
platform/viewer/src/appInit.js 0.00% <0.00%> (ø)
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd1c38c...3c5d974. Read the comment docs.

@pwespi
Copy link
Contributor Author

pwespi commented Jul 28, 2022

Rebased on to latest v3-stable.

cc @sedghi

@stale
Copy link

stale bot commented Jun 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale 🥖 label Jun 18, 2023
@sedghi
Copy link
Member

sedghi commented Jun 19, 2023

v3-stable has moved to master, feel free to change and update base with mater

@sedghi
Copy link
Member

sedghi commented Oct 4, 2023

closing in favor of #3697

@sedghi sedghi closed this Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants