-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
payer plan period criteria support for circe-be #11
Conversation
public NumericRange periodLength; | ||
|
||
@JsonProperty("AgeAtStart") | ||
public NumericRange ageAtstart; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raomane, @gowthamrao - hello, do you mean "ageAtStart"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree
ArrayList<String> whereClauses = new ArrayList<>(); | ||
|
||
//first | ||
if (criteria.first != null && criteria.first == true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think ... && criteria.first
is enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this is inline with other patterns.
e.g.
circe-be/src/main/java/org/ohdsi/circe/cohortdefinition/CohortExpressionQueryBuilder.java
Line 633 in 6b602fd
if (criteria.first != null && criteria.first == true) |
circe-be/src/main/java/org/ohdsi/circe/cohortdefinition/CohortExpressionQueryBuilder.java
Line 717 in 6b602fd
if (criteria.first != null && criteria.first == true) |
circe-be/src/main/java/org/ohdsi/circe/cohortdefinition/CohortExpressionQueryBuilder.java
Line 879 in 6b602fd
if (criteria.first != null && criteria.first == true) |
etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Local compile works, although we do not have a CDM v5.3 implementation to validate with.
Related to OHDSI/CommonDataModel#120
If/Once the proposal is accepted
@chrisknoll
OHDSI/WebAPI#217