fix pop sample

OHDSI · Nov 14, 2024 · c449eda · c449eda
1 parent 9404ad0
commit c449eda
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/R/populationDiagnostics.R b/R/populationDiagnostics.R
@@ -31,8 +31,11 @@ populationDiagnostics <- function(cohort,
   denominatorTable <- omopgenerics::uniqueTableName()
 
   # add population sampling
+  if(!is.null(populationSample)){
+    cli::cli_bullets(c("*" = "{.strong Sampling person table to {populationSample}}"))
   cdm$person <- cdm$person |>
     dplyr::slice_sample(n = populationSample)
+  }
 
   cdm <- IncidencePrevalence::generateDenominatorCohortSet(
     cdm = cdm,

diff --git a/tests/testthat/test-populationDiagnostics.R b/tests/testthat/test-populationDiagnostics.R
@@ -1,8 +1,10 @@
 test_that("population incidence and prevalence", {
   cdm <- IncidencePrevalence::mockIncidencePrevalenceRef(sampleSize = 1000)
   cdm <- IncidencePrevalence::generateDenominatorCohortSet(cdm, name = "denom")
-  expect_no_error(pop_diag <- populationDiagnostics(cohort = cdm$outcome,
+  expect_no_error(pop_diag_sample <- populationDiagnostics(cohort = cdm$outcome,
                                     populationSample = 250))
+  expect_no_error(pop_diag_no_sample <- populationDiagnostics(cohort = cdm$outcome,
+                                    populationSample = NULL))
 
   CDMConnector::cdm_disconnect(cdm)