Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Study population improvements #424

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Conversation

egillax
Copy link
Collaborator

@egillax egillax commented Dec 21, 2023

  • Minor speed improvements by moving filter operations before joins
  • Fixed a bug where creatingStudyPopulation with an existing pop failed sometimes (I think when multiple outcome cohorts were present in plpData$outcomes and/or when each subject had multiple observations)

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b6fb110) 89.41% compared to head (5bb4c8a) 89.38%.
Report is 1 commits behind head on develop.

Files Patch % Lines
R/PopulationSettings.R 71.42% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #424      +/-   ##
===========================================
- Coverage    89.41%   89.38%   -0.03%     
===========================================
  Files           49       49              
  Lines         9827     9829       +2     
===========================================
- Hits          8787     8786       -1     
- Misses        1040     1043       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@egillax egillax merged commit 988221c into develop Dec 21, 2023
9 of 12 checks passed
@egillax egillax deleted the study_population_improvements branch December 21, 2023 16:30
egillax added a commit that referenced this pull request Apr 5, 2024
* Update DESCRIPTION

* only resrtict to first if many observations per subjectId

* fix assignment operator in configurePython (#421)

* Tibble dependancy removal (#422)

* remove unnecessary remotes (#423)

* Study population improvements (#424)

* assign population if existing and added a test (#428)

* 429 save cdm database name (#430)

* save dev database name and schema in trainDetails (#434)

* preserve attributes when splitting data

* Prevent plpData from being evaluated during do.call (#436)

* test improvements (#438)

* fix duplicate vignette titles

---------

Co-authored-by: jreps <[email protected]>
Co-authored-by: Henrik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant