remove skip_on_cran

OHDSI · Aug 20, 2024 · 351355e · 351355e
1 parent a6719f4
commit 351355e
Show file tree

Hide file tree

Showing 16 changed files with 2 additions and 95 deletions.
diff --git a/tests/testthat/test-Aggregation.R b/tests/testthat/test-Aggregation.R
@@ -30,7 +30,6 @@ test_that("aggregateCovariates works", {
 })
 
 test_that("aggregateCovariates handles temporalCovariates", {
-  skip_on_cran()
   skip_if_not(dbms == "sqlite" && exists("eunomiaConnection"))
   settings <- createTemporalCovariateSettings(useDemographicsGender = TRUE)
   covariateData <- getDbCovariateData(

diff --git a/tests/testthat/test-CompareCohorts.R b/tests/testthat/test-CompareCohorts.R
@@ -3,7 +3,6 @@
 # covr::file_report(covr::file_coverage("R/CompareCohorts.R", "tests/testthat/test-CompareCohorts.R"))
 
 test_that("Test stdDiff continuous variable computation", {
-  skip_on_cran()
   # NOTE: Data stored in "inst/testdata/continuousCovariateData.zip" created by:
   # ------------------------------------------------------------------------------
   # connectionDetails <- Eunomia::getEunomiaConnectionDetails()

diff --git a/tests/testthat/test-CovariateData.R b/tests/testthat/test-CovariateData.R
@@ -3,7 +3,6 @@
 # covr::file_report(covr::file_coverage("R/CovariateData.R", "tests/testthat/test-CovariateData.R"))
 
 test_that("test CovariateData Class on Empty", {
-  skip_on_cran()
   skip_if_not(dbms == "sqlite")
   # create 4 scenarios of Covariate Data
   # 1) error (non class), 2) covariate data, 3) aggregatedCovariate Data,
@@ -80,7 +79,6 @@ test_that("test saveCovariateData error cases", {
 })
 
 test_that("test summary call for covariateData class", {
-  skip_on_cran()
   skip_if_not(dbms == "sqlite" && exists("eunomiaConnection"))
   settings <- createDefaultCovariateSettings()
   covariateData <- getDbCovariateData(
@@ -130,12 +128,10 @@ test_that("test filtering of covariates based on minCharacterizationMean", {
 })
 
 test_that("test loadCovariateData", {
-  skip_on_cran()
   expect_error(loadCovariateData("errorPath"))
 })
 
 test_that("Test exit/warning conditions", {
-  skip_on_cran()
   # Empty Directory test
   tempDir <- tempdir()
   expect_error(loadCovariateData(file = tempDir))
@@ -152,7 +148,6 @@ test_that("Test exit/warning conditions", {
 })
 
 test_that("Test show method", {
-  skip_on_cran()
   cvData <- FeatureExtraction::createEmptyCovariateData(cohortIds = c(1, 2), aggregated = FALSE, temporal = FALSE)
   expect_invisible(show(cvData))
   on.exit(rm(cvData))

diff --git a/tests/testthat/test-DetailedCovariateSettings.R b/tests/testthat/test-DetailedCovariateSettings.R
@@ -1,6 +1,5 @@
 # This file covers the code in DetailedCovariateData.R. View coverage for this file using
 test_that("test createDetailedCovariateSettings", {
-  skip_on_cran()
   analysisDetails <- createAnalysisDetails(
     analysisId = 1,
     sqlFileName = "DemographicsGender.sql",
@@ -24,7 +23,6 @@ test_that("test createDetailedCovariateSettings", {
 })
 
 test_that("test createDetailedTemporalCovariateSettings", {
-  skip_on_cran()
   analysisDetails <- createAnalysisDetails(
     analysisId = 1,
     sqlFileName = "DemographicsGender.sql",
@@ -46,7 +44,6 @@ test_that("test createDetailedTemporalCovariateSettings", {
 })
 
 test_that("test convertPrespecSettingsToDetailedSettings", {
-  skip_on_cran()
   settings <- createCovariateSettings(useDemographicsAgeGroup = TRUE, useChads2Vasc = TRUE)
   convertedSettings <- convertPrespecSettingsToDetailedSettings(settings)
   expect_s3_class(convertedSettings, "covariateSettings")
@@ -55,13 +52,11 @@ test_that("test convertPrespecSettingsToDetailedSettings", {
 })
 
 test_that("test createDefaultCovariateSettings", {
-  skip_on_cran()
   settings <- createDefaultCovariateSettings()
   expect_s3_class(settings, "covariateSettings")
 })
 
 test_that("test createDefaultTemporalCovariateSettings", {
-  skip_on_cran()
   settings <- createDefaultTemporalCovariateSettings()
   expect_s3_class(settings, "covariateSettings")
 })
diff --git a/tests/testthat/test-FeatureExtractionInternal.R b/tests/testthat/test-FeatureExtractionInternal.R
@@ -3,14 +3,12 @@
 # covr::file_report(covr::file_coverage("R/FeatureExtraction.R", "tests/testthat/test-FeatureExtractionInternal.R"))
 
 test_that("Test .onLoad()", {
-  skip_on_cran()
   expect_silent(
     FeatureExtraction:::.onLoad(libname = "FeatureExtraction", pkgname = "FeatureExtraction")
   )
 })
 
 test_that("Test JSON functions", {
-  skip_on_cran()
   expectedToJsonResult <- "{\"id\":\"1\"}"
   expectedFromJsonResult <- list("id" = "1")
   toJsonResult <- FeatureExtraction:::.toJson(expectedFromJsonResult)