Rethink how dplyr is rendered to sql when using DatabaseConnector #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .github/workflows/R_CMD_check_Hades.yaml # .github/workflows/R_CMD_check_main_weekly.yaml
|
to get rcheck to pass I will need to update the documentation which means a lot of files will change. However these changes are autogenerated so don't need to be reviewed. Only the changes in the R/ folder need review. Then I simply ran |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #258 +/- ##
===========================================
- Coverage 60.49% 0.00% -60.50%
===========================================
Files 15 15
Lines 2521 2537 +16
===========================================
- Hits 1525 0 -1525
- Misses 996 2537 +1541 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linked issue #257