Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a failure option based on row count? #95

Closed
clairblacketer opened this issue Feb 23, 2020 · 2 comments · Fixed by #291
Closed

Add a failure option based on row count? #95

clairblacketer opened this issue Feb 23, 2020 · 2 comments · Fixed by #291
Assignees
Labels
enhancement New feature or request

Comments

@clairblacketer
Copy link
Collaborator

clairblacketer commented Feb 23, 2020

Should we add an option to define failures based on row count? For example, if it is a large database 100 records that fail still looks like 0.00% failure because of the sig figs we are using. In this example, I see records that occur in the year 2100 but it did not flag as a fail. I still want to know that this is happening and adding a definition based on row count could do that.

Or add row count as a column?

@clairblacketer clairblacketer self-assigned this Mar 3, 2022
@clairblacketer clairblacketer added the enhancement New feature or request label Mar 3, 2022
@clairblacketer
Copy link
Collaborator Author

Row count is now in the output

@clairblacketer clairblacketer removed their assignment Mar 10, 2022
@clairblacketer
Copy link
Collaborator Author

From Maxim - add a line of code that says "if you set the threshold to zero then not one row should fail"

@MaximMoinat MaximMoinat self-assigned this Mar 11, 2022
MaximMoinat pushed a commit to thehyve/OHDSI-DataQualityDashboard that referenced this issue Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants