Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is the _start_datetime required? #131

Closed
MaximMoinat opened this issue Oct 24, 2017 · 3 comments
Closed

Is the _start_datetime required? #131

MaximMoinat opened this issue Oct 24, 2017 · 3 comments
Assignees
@clairblacketer
Labels
Bug

Comments

@MaximMoinat
Copy link
Collaborator

MaximMoinat commented Oct 24, 2017 •
edited
Loading

According to the documentation, the _start_datetime columns in e.g. the drug_exposure table are not required. However, it is set to NOT NULL in the definitions.

Is the start datetime column indeed required? And if so, what is the convention of setting the time if only a date is available?
@MaximMoinat MaximMoinat changed the title Postgres ddl: column drug_exposure_start_datetime not null Is the _start_datetime required? Oct 24, 2017
@cgreich
Copy link
Contributor

cgreich commented Oct 25, 2017

@MaximMoinat:

You are right. We need somebody who can watch these things and engage with the community and accept pull requests. Maybe @leeevans. Let me find out.

@clairblacketer clairblacketer self-assigned this Oct 25, 2017
clairblacketer added a commit that referenced this issue Nov 9, 2017
@clairblacketer
Addresses #64, #70, #79, #92, #120, #132, #131 in code, documentation…
afd9a52 
… is still being updated to reflect these changes.
@vojtechhuser
Copy link
Collaborator

can this be closed? is it still an issue?

@clairblacketer
Copy link
Contributor

It has been closed in v5.3

@clairblacketer clairblacketer mentioned this issue Jan 3, 2018
Merged
@MelaniePhilofsky MelaniePhilofsky mentioned this issue Apr 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clairblacketer clairblacketer

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cgreich @vojtechhuser @clairblacketer @MaximMoinat