Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add @export to roxy header for isAndromedaTable() #70

Merged
merged 5 commits into from
Dec 17, 2024
Merged

add @export to roxy header for isAndromedaTable() #70

merged 5 commits into from
Dec 17, 2024

Conversation

ob325
Copy link

@ob325 ob325 commented Dec 16, 2024

No description provided.

@msuchard
Copy link
Member

@ob325 -- please add the change to NAMESPACE as well.

@msuchard msuchard marked this pull request as draft December 17, 2024 03:26
@ob325
Copy link
Author

ob325 commented Dec 17, 2024

I believe NAMESPACE is already correct in the duckdb2 branch (i.e. it does export isAndromedaTable like we want). It is missing only in the duckdb branch.

@msuchard
Copy link
Member

my apologies, @ob325, and thanks for gracefully handling my pedanticness .

@msuchard msuchard marked this pull request as ready for review December 17, 2024 15:25
@msuchard msuchard merged commit 2b0549c into OHDSI:duckdb2 Dec 17, 2024
1 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msuchard msuchard msuchard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ob325 @msuchard