Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devel #3157

Merged
merged 3 commits into from
Jul 14, 2024
Merged

Devel #3157

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions CMake/Dependencies.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -160,21 +160,21 @@ if(OGRE_BUILD_DEPENDENCIES AND NOT EXISTS ${OGREDEPS_PATH})

message(STATUS "Building Assimp")
file(DOWNLOAD
https://github.com/assimp/assimp/archive/refs/tags/v5.4.0.tar.gz
${PROJECT_BINARY_DIR}/v5.4.0.tar.gz)
https://github.com/assimp/assimp/archive/refs/tags/v5.4.2.tar.gz
${PROJECT_BINARY_DIR}/v5.4.2.tar.gz)
execute_process(COMMAND ${CMAKE_COMMAND}
-E tar xf v5.4.0.tar.gz WORKING_DIRECTORY ${PROJECT_BINARY_DIR})
-E tar xf v5.4.2.tar.gz WORKING_DIRECTORY ${PROJECT_BINARY_DIR})
execute_process(COMMAND ${BUILD_COMMAND_COMMON}
-DZLIB_ROOT=${OGREDEPS_PATH}
-DBUILD_SHARED_LIBS=OFF
-DASSIMP_BUILD_TESTS=OFF
-DASSIMP_NO_EXPORT=TRUE
-DASSIMP_BUILD_OGRE_IMPORTER=OFF
-DASSIMP_BUILD_ASSIMP_TOOLS=OFF
${PROJECT_BINARY_DIR}/assimp-5.4.0
WORKING_DIRECTORY ${PROJECT_BINARY_DIR}/assimp-5.4.0)
${PROJECT_BINARY_DIR}/assimp-5.4.2
WORKING_DIRECTORY ${PROJECT_BINARY_DIR}/assimp-5.4.2)
execute_process(COMMAND ${CMAKE_COMMAND}
--build ${PROJECT_BINARY_DIR}/assimp-5.4.0 ${BUILD_COMMAND_OPTS})
--build ${PROJECT_BINARY_DIR}/assimp-5.4.2 ${BUILD_COMMAND_OPTS})
endif()

message(STATUS "Building Bullet")
Expand Down
6 changes: 3 additions & 3 deletions Components/Overlay/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ list(APPEND HEADER_FILES
file(GLOB SOURCE_FILES "${CMAKE_CURRENT_SOURCE_DIR}/src/*.cpp")

if(OGRE_BUILD_COMPONENT_OVERLAY_IMGUI)
set(IMGUI_DIR "${PROJECT_BINARY_DIR}/imgui-1.90.4" CACHE PATH "")
set(IMGUI_DIR "${PROJECT_BINARY_DIR}/imgui-1.90.9" CACHE PATH "")
if(NOT EXISTS ${IMGUI_DIR})
message(STATUS "Downloading imgui")
file(DOWNLOAD
https://github.com/ocornut/imgui/archive/v1.90.4.tar.gz
https://github.com/ocornut/imgui/archive/v1.90.9.tar.gz
${PROJECT_BINARY_DIR}/imgui.tar.gz)
execute_process(COMMAND ${CMAKE_COMMAND}
-E tar xf imgui.tar.gz WORKING_DIRECTORY ${PROJECT_BINARY_DIR})
Expand Down Expand Up @@ -76,7 +76,7 @@ if(OGRE_BUILD_COMPONENT_OVERLAY_IMGUI)
set_source_files_properties(${IMGUI_DIR}/imgui_draw.cpp PROPERTIES
COMPILE_FLAGS "-Wno-cast-qual")
set_source_files_properties(${IMGUI_DIR}/imgui.cpp PROPERTIES
COMPILE_FLAGS "-Wno-cast-qual")
COMPILE_FLAGS "-Wno-cast-qual -Wno-unused-variable")
if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
set_property(SOURCE ${IMGUI_DIR}/misc/freetype/imgui_freetype.cpp
APPEND PROPERTY COMPILE_OPTIONS "-Wno-unknown-warning-option")
Expand Down
1 change: 1 addition & 0 deletions OgreMain/src/OgreMeshSerializerImpl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2003,6 +2003,7 @@ namespace Ogre {
size_t size = MSTREAM_OVERHEAD_SIZE;
// float time
size += sizeof(float);
size += sizeof(char); // bool includesNormals
// float x,y,z[,nx,ny,nz]
bool includesNormals = kf->getVertexBuffer()->getVertexSize() > (sizeof(float) * 3);
size += sizeof(float) * (includesNormals ? 6 : 3) * vertexCount;
Expand Down