Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main: fix spelling error #2943

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Main: fix spelling error #2943

merged 2 commits into from
Nov 3, 2023

Conversation

chillywillysoft
Copy link
Contributor

I introduced a spelling error (frustrum instead of frustum) with this commit. Hopefully fixing it isn't too breaking. I doubt many people have tested for frustums since 14 came out and updating any broken code should be trivial.

@paroj
Copy link
Member

paroj commented Sep 14, 2023

I doubt many people have tested for frustums

the issue forward compatibility. Some code might be written against 14.0 due to distro packaging or similar. This must continue working with any 14.x release.

Therefore, please use this pattern:

/// @deprecated use #SRS_SHADOW_MAPPING
_OgreRTSSExport extern const String SRS_INTEGRATED_PSSM3;
/// shadow mapping receiver with multiple lights or single PSSM light with up to 3 custom splits.
_OgreRTSSExport extern const String SRS_SHADOW_MAPPING;

@paroj paroj added this to the 14.x milestone Sep 14, 2023
@paroj paroj marked this pull request as draft September 15, 2023 09:51
@paroj
Copy link
Member

paroj commented Sep 15, 2023

For 14.1.x this still would break backwards compatibility. I will merge this in time for 14.2. Set to draft so I dont merge it by accident.

@chillywillysoft
Copy link
Contributor Author

Sounds good. But just so I understand/learn, how does this break backwards compatibility? The string didn't change, it still has the old constant name and now it has a new constant name.

@paroj
Copy link
Member

paroj commented Sep 15, 2023

how does this break backwards compatibility?

imagine someone writes code against 14.1.1 (with this change) and then needs to deploy it with 14.1.0

@chillywillysoft
Copy link
Contributor Author

Ah, I think I see. Not to nitpick but if I understand correctly, what you call not backward compatible is what semver calls "new, backward compatible"? So waiting for the next minor makes perfect sense.

@paroj paroj marked this pull request as ready for review November 3, 2023 20:05
@paroj paroj merged commit a8dedc8 into OGRECave:master Nov 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants