move the adjacency flag to render operation where it belongs ogre-next-3-0 #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 26, 2024 12:44
…of the geometry shader - for e.g. rendering adjacency buffers without an geometry shader attached.
…ationType. The D3D11RenderSystem::_hlmsPipelineStateObjectCreated didn't properly initialized the D3D11HlmsPso::topology and in GL3PlusRenderSystem::_setPipelineStateObject the mUseAdjacency member was not correctly intialized.
…imply overwritten, but it should be set to true only if geometry shader explicitly set it, otherwise the value must be preserved from the initialization where it could be already set to true.
darksylinc
reviewed
Jul 26, 2024
OgreMain/include/OgreGpuProgram.h
Outdated
| /** Sets whether this geometry program requires adjacency information | ||
| from the input primitives. | ||
| */ | ||
| /// @deprecated |
There was a problem hiding this comment.
Regarding deprecation we introduced the OGRE_DEPRECATED_VER( n ) macro where n is the major version in which it was deprecated.
Thus the code should look like this:
OGRE_DEPRECATED_VER( 4 ) virtual bool isAdjacencyInfoRequired()(master branch is currently 4)
|
I've pushed two changes to your PR (one to fix Clang Format, another to port your enum changes to Vulkan). Once CI is done checking I'll merge your PR. |
|
Thank you for the PR!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move the adjacency flag to render operation where it belongs instead of the geometry shader - for e.g. rendering adjacency buffers without an geometry shader attached.