Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tutorial00 on macOS #223

Merged
merged 3 commits into from
Sep 26, 2021
Merged

Conversation

jwwalker
Copy link
Contributor

Sample_Tutorial00_Basic was hanging without displaying anything past the configuration dialog when run on macOS with Metal. These changes add enough event handling so that it doesn't look hung and it can be quit by clicking the window close box.

@darksylinc
Copy link
Member

Niiiice!!! Thank you!

I'll be giving it a try in the next few days, if all goes ok I'll merge it

@darksylinc darksylinc merged commit 61e2659 into OGRECave:master Sep 26, 2021
@darksylinc
Copy link
Member

Thanks for your PR!!

The only thing that could be improved is that writeAccessFolder = /Users/user/Library/Logs may be fine for Ogre.log but it is not for Ogre.cfg, since that's where we are supposed to store our config (that persists after multiple launches).

@jwwalker
Copy link
Contributor Author

I see; for writeAccessFolder, a better choice might be ~/Library/Application Support/Ogre .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants