-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 1D heateq example #102
base: main
Are you sure you want to change the base?
Conversation
- Fixes a bug in the enthalpy inverse function - Initial implementation of a benchmarking loop for comparing adjoint performance TODO: why is checkpointing always slower and requiring more allocations than no checkpointing??
@ChrisRackauckas and @facusapienza21 Could you guys tell me if I am doing something stupid here? For some reason, enabling checkpointing with I separated the forward solve from the adjoint calculation using Note that I reduced the size of the problem to make testing easier. It's now only ~150 MOL equations. This can be easily adjusted with the Sorry for the messy code... still a WIP. |
@bgroenks96 What do you want to do with this PR? |
I guess just close it? It's a shame that it didn't make it into the paper, but I unfortunately don't really have the time (or motivation) to dig further into the details of benchmarking checkpointing 🤷♂️ |
Oh wait, I forgot that it fixed a bug... maybe we should merge it actually, if possible. |
adf141a
to
fe9506d
Compare
TODO: why is checkpointing always slower and requiring more allocations than no checkpointing??