Fix dockerfile

[joschrew]

In addition to fixes for making the image creation actually work, I added some labels according to this: OCR-D/ocrd_kraken#45.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.50%. Comparing base (d9cde1f) to head (37df6d8).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #119   +/-   ##
=======================================
  Coverage   69.50%   69.50%           
=======================================
  Files           5        5           
  Lines         223      223           
  Branches       57       51    -6     
=======================================
  Hits          155      155           
- Misses         53       54    +1     
+ Partials       15       14    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bertsky]

Thanks!

We could really use a CD, too. Example via GHA: ocrd_kraken, example via CircleCI: ocrd_cis

[joschrew]

I added a CD for pushing the image, used ocrd_kraken-CD as template. Secrets for dockerhub are currently missing

[bertsky]

I added a CD for pushing the image, used ocrd_kraken-CD as template. Secrets for dockerhub are currently missing

Fantastic!

@kba?

[mikegerber]

LGTM

What convention do you currently use for the Docker tags? latest is commonly used elsewhere for the latest stable version, but this seems to be using latest for master?

[mikegerber]

LGTM

[joschrew]

Thank you!

What convention do you currently use for the Docker tags?

I don't know if we follow any convention other then simply using latest when pushing newer images. But maybe @bertsky knows more?

[kba]

LGTM. DOCKERIO_{PASSWORD,USERNAME} are set, let's see whether CD works 🤞

[mikegerber]

Merged. I'll check the build and open new issues if necessary.