Disable ocrd_anybaseocr and sbb_binarization for Python 3.11 #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Weil <[email protected]>
kba
reviewed
Sep 11, 2024
There was a problem hiding this comment.
I would prefer to first do the refactoring of ocrd_anybaseocr. sbb_binarization will be gone once we have the binarization made available from eynollah. I am just swamped with other work but hope to get back to ocrd_all and core next week. But let's discuss in the tech call later.
|
Sorry, I could not attend the meeting today. Both modules are disabled for Python 3.11 because they break the build today (including any CI tests with Python 3.11). So there are not many alternatives to this pull request: neither forbidding Python 3.11 nor requiring local patches would be good solutions. If things change in the future, a module can be added again or be removed of course. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.