Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR notifications - add analytics, update CTAs & display light pages alerts #6462

Closed
wants to merge 4 commits into from

Conversation

ccataalin
Copy link
Contributor

@ccataalin ccataalin commented Oct 25, 2024

  • HDX-10249 implement Mixpanel tracking
  • HDX-10238 update CTA buttons
  • HDXDPT-1119 display alerts on light pages

@ccataalin ccataalin changed the title HDX-10249 implement Mixpanel analytics for notifications PR notifications - add analytics, update CTAs & display light pages alerts Oct 28, 2024
@coveralls
Copy link

coveralls commented Oct 28, 2024

Pull Request Test Coverage Report for Build #5805

Details

  • 27 of 35 (77.14%) changed or added relevant lines in 6 files are covered.
  • 122 unchanged lines in 16 files lost coverage.
  • Overall coverage decreased (-0.2%) to 73.887%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ckanext-hdx_package/ckanext/hdx_package/views/dataset.py 2 3 66.67%
ckanext-hdx_users/ckanext/hdx_users/helpers/analytics.py 2 5 40.0%
ckanext-hdx_users/ckanext/hdx_users/views/notification_platform.py 2 6 33.33%
Files with Coverage Reduction New Missed Lines %
ckanext-hdx_org_group/ckanext/hdx_org_group/helpers/org_batch.py 1 95.65%
ckanext-hdx_users/ckanext/hdx_users/plugin.py 2 95.16%
ckanext-hdx_users/ckanext/hdx_users/views/notification_platform.py 2 26.53%
ckanext-hdx_theme/ckanext/hdx_theme/hxl/operations/recipes.py 3 60.0%
ckanext-hdx_theme/ckanext/hdx_theme/hxl/transformers/transformers.py 3 71.43%
ckanext-hdx_theme/ckanext/hdx_theme/hxl/operations/operations.py 4 55.56%
ckanext-hdx_theme/ckanext/hdx_theme/views/count.py 4 43.18%
ckanext-hdx_theme/ckanext/hdx_theme/helpers/actions.py 4 62.54%
ckanext-hdx_hxl_preview/ckanext/hdx_hxl_preview/plugin.py 5 82.35%
ckanext-hdx_package/ckanext/hdx_package/actions/get.py 6 75.34%
Totals Coverage Status
Change from base Build #5800: -0.2%
Covered Lines: 12229
Relevant Lines: 16551

💛 - Coveralls

@ccataalin ccataalin closed this Oct 28, 2024
@ccataalin
Copy link
Contributor Author

merged into prod, see #6463.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants