Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDX-9960 & HDX-9987 contact the contributor & HDX Connect new pages #6412

Merged
merged 7 commits into from
Aug 29, 2024
Merged

HDX-9960 & HDX-9987 contact the contributor & HDX Connect new pages #6412

merged 7 commits into from
Aug 29, 2024

Conversation

ccataalin
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Aug 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #5654

Details

  • 266 of 323 (82.35%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 73.648%
Changes Missing Coverage Covered Lines Changed/Added Lines %
ckanext-hdx_org_group/ckanext/hdx_org_group/helpers/organization_helper.py 4 5 80.0%
ckanext-hdx_package/ckanext/hdx_package/actions/authorize.py 5 6 83.33%
ckanext-hdx_package/ckanext/hdx_package/controller_logic/dataset_contact_contributor_logic.py 34 36 94.44%
ckanext-hdx_theme/ckanext/hdx_theme/helpers/helpers.py 25 36 69.44%
ckanext-hdx_package/ckanext/hdx_package/controller_logic/dataset_request_access_logic.py 73 93 78.49%
ckanext-hdx_package/ckanext/hdx_package/views/dataset.py 119 141 84.4%
Totals Coverage Status
Change from base Build #5644: 0.7%
Covered Lines: 11875
Relevant Lines: 16124
💛 - Coveralls

@ccataalin ccataalin changed the title HDX-9960 implement the new contact the contributor page HDX-9960 & HDX-9987 contact the contributor & HDX Connect new pages Aug 26, 2024
@ccataalin ccataalin marked this pull request as ready for review August 26, 2024 11:34
@danmihaila danmihaila merged commit 8a716d0 into dev Aug 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandru-m-g alexandru-m-g alexandru-m-g approved these changes

@danmihaila danmihaila Awaiting requested review from danmihaila

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ccataalin @coveralls @alexandru-m-g @danmihaila