Apply code review suggestions

OCA · Jun 15, 2020 · f5d93ca · f5d93ca
1 parent ac8b9bd
commit f5d93ca
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 2 deletions.
diff --git a/stock_dynamic_routing/__manifest__.py b/stock_dynamic_routing/__manifest__.py
@@ -1,9 +1,9 @@
 # Copyright 2019 Camptocamp (https://www.camptocamp.com)
 {
     "name": "Stock Dynamic Routing",
-    "summary": "Dynamic routing for special locations",
+    "summary": "Dynamic routing of stock moves",
     "author": "Camptocamp, Odoo Community Association (OCA)",
-    "website": "https://github.com/OCA/stock-logistics-warehouse",
+    "website": "https://github.com/OCA/wms",
     "category": "Warehouse Management",
     "version": "13.0.1.0.0",
     "license": "AGPL-3",

diff --git a/stock_dynamic_routing/models/stock_routing.py b/stock_dynamic_routing/models/stock_routing.py
@@ -247,6 +247,13 @@ def __cached_is_rule_valid_for_move(self, rule, move):
         The method _routing_rule_for_move(_line)s reset the cache at beginning.
         Cache the result so inside _routing_rule_for_move(_line)s, we compute it
         only once for a move and a rule (if we have several move lines).
+
+        This method is part of the internal machinery of the algorithm to
+        find rules. It exists so we can have a local cache during the time of a
+        transaction, and is not meant to be overriden in any way.
+
+        If you wish to customize the validity of a rule, you should extend
+        ``StockRoutingRule._is_valid_for_moves()``
         """
         return rule._is_valid_for_moves(move)
 

diff --git a/stock_dynamic_routing/tests/test_routing_pull.py b/stock_dynamic_routing/tests/test_routing_pull.py
@@ -7,6 +7,7 @@ class TestRoutingPullCommon(common.SavepointCase):
     @classmethod
     def setUpClass(cls):
         super().setUpClass()
+        cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True))
         cls.partner_delta = cls.env.ref("base.res_partner_4")
         cls.wh = cls.env["stock.warehouse"].create(
             {

diff --git a/stock_dynamic_routing/tests/test_routing_push.py b/stock_dynamic_routing/tests/test_routing_push.py
@@ -7,6 +7,7 @@ class TestRoutingPush(common.SavepointCase):
     @classmethod
     def setUpClass(cls):
         super().setUpClass()
+        cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True))
         cls.partner_delta = cls.env.ref("base.res_partner_4")
         cls.wh = cls.env["stock.warehouse"].create(
             {

diff --git a/stock_dynamic_routing/tests/test_routing_rule.py b/stock_dynamic_routing/tests/test_routing_rule.py
@@ -7,6 +7,7 @@ class TestRoutingRule(common.SavepointCase):
     @classmethod
     def setUpClass(cls):
         super().setUpClass()
+        cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True))
         cls.product = cls.env["product.product"].create(
             {"name": "Product", "type": "product"}
         )