[8.0][IMP][website_canonical_url] Safer, prefer root, relative paths #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids a possible `KeyError`.
Makes this work fine behind an HTTPS proxy.
pedrobaeza
reviewed
Sep 30, 2016
| @@ -10,7 +10,7 @@ | |||
| 'author': "initOS GmbH, Odoo Community Association (OCA)", | |||
yajo
force-pushed
the
8.0-website_canonical_url-relative_safe_root
branch
from
1f210c7 to
1f947d5
Compare
The root path canonicalized is more SEO and user friendly.
yajo
force-pushed
the
8.0-website_canonical_url-relative_safe_root
branch
from
1f947d5 to
6e64017
Compare
pedrobaeza
approved these changes
Oct 11, 2016
yajo
added a commit
to Tecnativa/website
that referenced
this pull request
Dec 19, 2016
…CA#260) [IMP] website_canoncial_url: Several improvements * Use safe method to retrieve lang. This avoids a possible `KeyError`. * Use relative paths. Makes this work fine behind an HTTPS proxy. * Prefer `/` over `/page/homepage`. The root path canonicalized is more SEO and user friendly.
yajo
added a commit
to Tecnativa/website
that referenced
this pull request
Dec 19, 2016
…CA#260) [IMP] website_canoncial_url: Several improvements * Use safe method to retrieve lang. This avoids a possible `KeyError`. * Use relative paths. Makes this work fine behind an HTTPS proxy. * Prefer `/` over `/page/homepage`. The root path canonicalized is more SEO and user friendly.
yajo
added a commit
to Tecnativa/website
that referenced
this pull request
Dec 21, 2016
…CA#260) [IMP] website_canoncial_url: Several improvements * Use safe method to retrieve lang. This avoids a possible `KeyError`. * Use relative paths. Makes this work fine behind an HTTPS proxy. * Prefer `/` over `/page/homepage`. The root path canonicalized is more SEO and user friendly.
pedrobaeza
pushed a commit
to Tecnativa/website
that referenced
this pull request
Dec 24, 2016
…CA#260) [IMP] website_canoncial_url: Several improvements * Use safe method to retrieve lang. This avoids a possible `KeyError`. * Use relative paths. Makes this work fine behind an HTTPS proxy. * Prefer `/` over `/page/homepage`. The root path canonicalized is more SEO and user friendly.
yajo
added a commit
to Tecnativa/website
that referenced
this pull request
Dec 27, 2016
…CA#260) [IMP] website_canoncial_url: Several improvements * Use safe method to retrieve lang. This avoids a possible `KeyError`. * Use relative paths. Makes this work fine behind an HTTPS proxy. * Prefer `/` over `/page/homepage`. The root path canonicalized is more SEO and user friendly.
yajo
added a commit
to Tecnativa/website
that referenced
this pull request
Dec 28, 2016
…CA#260) [IMP] website_canoncial_url: Several improvements * Use safe method to retrieve lang. This avoids a possible `KeyError`. * Use relative paths. Makes this work fine behind an HTTPS proxy. * Prefer `/` over `/page/homepage`. The root path canonicalized is more SEO and user friendly.
yajo
added a commit
to Tecnativa/website
that referenced
this pull request
Dec 28, 2016
…CA#260) [IMP] website_canoncial_url: Several improvements * Use safe method to retrieve lang. This avoids a possible `KeyError`. * Use relative paths. Makes this work fine behind an HTTPS proxy. * Prefer `/` over `/page/homepage`. The root path canonicalized is more SEO and user friendly.
reinka
pushed a commit
to reinka/website
that referenced
this pull request
Jun 6, 2017
[IMP] website_canoncial_url: Several improvements * Use safe method to retrieve lang. This avoids a possible `KeyError`. * Use relative paths. Makes this work fine behind an HTTPS proxy. * Prefer `/` over `/page/homepage`. The root path canonicalized is more SEO and user friendly.
reinka
pushed a commit
to reinka/website
that referenced
this pull request
Jun 7, 2017
[IMP] website_canoncial_url: Several improvements * Use safe method to retrieve lang. This avoids a possible `KeyError`. * Use relative paths. Makes this work fine behind an HTTPS proxy. * Prefer `/` over `/page/homepage`. The root path canonicalized is more SEO and user friendly.
reinka
pushed a commit
to reinka/website
that referenced
this pull request
Jun 7, 2017
[IMP] website_canoncial_url: Several improvements * Use safe method to retrieve lang. This avoids a possible `KeyError`. * Use relative paths. Makes this work fine behind an HTTPS proxy. * Prefer `/` over `/page/homepage`. The root path canonicalized is more SEO and user friendly.
reinka
pushed a commit
to reinka/website
that referenced
this pull request
Jun 16, 2017
[IMP] website_canoncial_url: Several improvements * Use safe method to retrieve lang. This avoids a possible `KeyError`. * Use relative paths. Makes this work fine behind an HTTPS proxy. * Prefer `/` over `/page/homepage`. The root path canonicalized is more SEO and user friendly.
reinka
pushed a commit
to reinka/website
that referenced
this pull request
Jun 16, 2017
[IMP] website_canoncial_url: Several improvements * Use safe method to retrieve lang. This avoids a possible `KeyError`. * Use relative paths. Makes this work fine behind an HTTPS proxy. * Prefer `/` over `/page/homepage`. The root path canonicalized is more SEO and user friendly.
simahawk
pushed a commit
to simahawk/website
that referenced
this pull request
Apr 20, 2018
…CA#260) [IMP] website_canoncial_url: Several improvements * Use safe method to retrieve lang. This avoids a possible `KeyError`. * Use relative paths. Makes this work fine behind an HTTPS proxy. * Prefer `/` over `/page/homepage`. The root path canonicalized is more SEO and user friendly.
simahawk
pushed a commit
to simahawk/website
that referenced
this pull request
May 11, 2018
…CA#260) [IMP] website_canoncial_url: Several improvements * Use safe method to retrieve lang. This avoids a possible `KeyError`. * Use relative paths. Makes this work fine behind an HTTPS proxy. * Prefer `/` over `/page/homepage`. The root path canonicalized is more SEO and user friendly.
simahawk
pushed a commit
to simahawk/website
that referenced
this pull request
May 16, 2018
…CA#260) [IMP] website_canoncial_url: Several improvements * Use safe method to retrieve lang. This avoids a possible `KeyError`. * Use relative paths. Makes this work fine behind an HTTPS proxy. * Prefer `/` over `/page/homepage`. The root path canonicalized is more SEO and user friendly.
pedrobaeza
pushed a commit
to simahawk/website
that referenced
this pull request
Jun 21, 2018
…CA#260) [IMP] website_canoncial_url: Several improvements * Use safe method to retrieve lang. This avoids a possible `KeyError`. * Use relative paths. Makes this work fine behind an HTTPS proxy. * Prefer `/` over `/page/homepage`. The root path canonicalized is more SEO and user friendly.
simahawk
pushed a commit
to simahawk/website
that referenced
this pull request
Jun 28, 2018
…CA#260) [IMP] website_canoncial_url: Several improvements * Use safe method to retrieve lang. This avoids a possible `KeyError`. * Use relative paths. Makes this work fine behind an HTTPS proxy. * Prefer `/` over `/page/homepage`. The root path canonicalized is more SEO and user friendly.
HviorForgeFlow
pushed a commit
to ForgeFlow/website
that referenced
this pull request
Oct 16, 2018
…CA#260) [IMP] website_canoncial_url: Several improvements * Use safe method to retrieve lang. This avoids a possible `KeyError`. * Use relative paths. Makes this work fine behind an HTTPS proxy. * Prefer `/` over `/page/homepage`. The root path canonicalized is more SEO and user friendly.
mfigueiredo-odoogap
pushed a commit
to odoogap/website
that referenced
this pull request
Dec 5, 2018
…CA#260) [IMP] website_canoncial_url: Several improvements * Use safe method to retrieve lang. This avoids a possible `KeyError`. * Use relative paths. Makes this work fine behind an HTTPS proxy. * Prefer `/` over `/page/homepage`. The root path canonicalized is more SEO and user friendly.
pedrobaeza
pushed a commit
to odoogap/website
that referenced
this pull request
Dec 14, 2018
…CA#260) [IMP] website_canoncial_url: Several improvements * Use safe method to retrieve lang. This avoids a possible `KeyError`. * Use relative paths. Makes this work fine behind an HTTPS proxy. * Prefer `/` over `/page/homepage`. The root path canonicalized is more SEO and user friendly.
cristinamartinrod
pushed a commit
to Tecnativa/website
that referenced
this pull request
Feb 26, 2019
…CA#260) [IMP] website_canoncial_url: Several improvements * Use safe method to retrieve lang. This avoids a possible `KeyError`. * Use relative paths. Makes this work fine behind an HTTPS proxy. * Prefer `/` over `/page/homepage`. The root path canonicalized is more SEO and user friendly.
HviorForgeFlow
pushed a commit
to ForgeFlow/website
that referenced
this pull request
Apr 23, 2020
…CA#260) [IMP] website_canoncial_url: Several improvements * Use safe method to retrieve lang. This avoids a possible `KeyError`. * Use relative paths. Makes this work fine behind an HTTPS proxy. * Prefer `/` over `/page/homepage`. The root path canonicalized is more SEO and user friendly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes this addon more SEO-friendly:
KeyErrorwhen no lang in context (could this ever happen? not sure, but preventing is easier)./, and that gets rerouted to your homepage (/page/homepageby default), then we canonicalize/instead. This is better because it fits more what the user would type in the URL bar, and removes stop words from the indexed URL.@Tecnativa