Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] [10.0] 2d widget fixes #712

Merged
merged 5 commits into from
Aug 30, 2017

Conversation

richard-willdooit
Copy link

Fixes display and input bugs in 2d widgets.

  • dataset.read_ids needs fields otherwise it returns no data
  • renderElement was loosing the change event handler
  • add standard odoo classes for read / edit mode hiding of alternate values
  • effective_readonly_change was switching same nodes twice

@pedrobaeza
Copy link
Member

Thanks for the patches. Maybe you can consider also the issue #697

Copy link
Member

@hbrunn hbrunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how easy it is to overlook stuff in reviews...

@hbrunn hbrunn added this to the 10.0 milestone Aug 30, 2017
@richard-willdooit
Copy link
Author

@pedrobaeza I actually don't use it with totals in my implementation. I don't think the totals render very well in version 10, but decided not to try and add this "enhancement", and I just did the fix to ensure correct recomputing.

@pedrobaeza
Copy link
Member

Thanks again, Richard, can you please make a last change that is modifying module version number for reflecting the evolution of the module?

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I squash at merge? As the only way to try here on runbot is to merge the PR and rebuild runbots that use it, I will merge. I would like to have demo data inside the module, but that would require to add code that can't be avoided when no demo data. @hbrunn do you have any possible idea?

@hbrunn
Copy link
Member

hbrunn commented Aug 30, 2017

first I thought you mean something like this, but now I understand you mean adding something that causes a field/wizard/view exist with demo=1 so that we can check stuff in runbot simpler?

Never tried this, but I had to detect runbot before, and maybe we can say

import socket
import os
if socket.getfqdn().endswith('odoo-community.org'):
    import my_demo_model

in models/__init__.py?

@pedrobaeza
Copy link
Member

@hbrunn thanks for the suggestion, but I don't really like a lot that because that will mean that I can't try in other DB except OCA runbot. I will think in this in my spare time and see if there's other option.

@hbrunn
Copy link
Member

hbrunn commented Aug 30, 2017

if you always want to add stuff in demo mode, using a hack like https://github.com/OCA/server-tools/pull/876/files#diff-ded7038d0dcfffc218c449b206263ebfR38 to get the current database's cursor, and then check if it has demo data enabled might work

@pedrobaeza
Copy link
Member

That's something I like more 😄 but as said, to be tried on my spare time, which is very little...

simahawk pushed a commit to simahawk/web that referenced this pull request Mar 27, 2018
* Patches to make module operational.
* Minor fix to Readonly Switch
* Fix to render to set change attribute.
* Totals recompute.

Fixes OCA#697
fmdl pushed a commit to fmdl/web that referenced this pull request May 1, 2018
* Patches to make module operational.
* Minor fix to Readonly Switch
* Fix to render to set change attribute.
* Totals recompute.

Fixes OCA#697
yaniaular pushed a commit to vauxoo-dev/web that referenced this pull request May 14, 2018
* Patches to make module operational.
* Minor fix to Readonly Switch
* Fix to render to set change attribute.
* Totals recompute.

Fixes OCA#697
yaniaular pushed a commit to vauxoo-dev/web that referenced this pull request May 14, 2018
* Patches to make module operational.
* Minor fix to Readonly Switch
* Fix to render to set change attribute.
* Totals recompute.

Fixes OCA#697
alexey-pelykh pushed a commit to brainbeanapps/web that referenced this pull request Nov 9, 2018
* Patches to make module operational.
* Minor fix to Readonly Switch
* Fix to render to set change attribute.
* Totals recompute.

Fixes OCA#697
alexey-pelykh pushed a commit to brainbeanapps/web that referenced this pull request Nov 9, 2018
* Patches to make module operational.
* Minor fix to Readonly Switch
* Fix to render to set change attribute.
* Totals recompute.

Fixes OCA#697
yajo pushed a commit that referenced this pull request Nov 20, 2018
* Patches to make module operational.
* Minor fix to Readonly Switch
* Fix to render to set change attribute.
* Totals recompute.

Fixes #697
AdriaGForgeFlow pushed a commit to ForgeFlow/web that referenced this pull request Jan 10, 2020
* Patches to make module operational.
* Minor fix to Readonly Switch
* Fix to render to set change attribute.
* Totals recompute.

Fixes OCA#697
AdriaGForgeFlow pushed a commit to ForgeFlow/web that referenced this pull request Feb 14, 2020
* Patches to make module operational.
* Minor fix to Readonly Switch
* Fix to render to set change attribute.
* Totals recompute.

Fixes OCA#697
AdriaGForgeFlow pushed a commit to ForgeFlow/web that referenced this pull request Mar 5, 2020
* Patches to make module operational.
* Minor fix to Readonly Switch
* Fix to render to set change attribute.
* Totals recompute.

Fixes OCA#697
Saran440 pushed a commit to ecosoft-odoo/web that referenced this pull request Nov 13, 2020
* Patches to make module operational.
* Minor fix to Readonly Switch
* Fix to render to set change attribute.
* Totals recompute.

Fixes OCA#697
Saran440 pushed a commit to ecosoft-odoo/web that referenced this pull request Nov 13, 2020
* Patches to make module operational.
* Minor fix to Readonly Switch
* Fix to render to set change attribute.
* Totals recompute.

Fixes OCA#697
pniederlag pushed a commit to datenbetrieb/web that referenced this pull request Dec 26, 2020
* Patches to make module operational.
* Minor fix to Readonly Switch
* Fix to render to set change attribute.
* Totals recompute.

Fixes OCA#697
ChrisOForgeFlow pushed a commit to ForgeFlow/web that referenced this pull request Dec 13, 2021
* Patches to make module operational.
* Minor fix to Readonly Switch
* Fix to render to set change attribute.
* Totals recompute.

Fixes OCA#697
LoisRForgeFlow pushed a commit to ForgeFlow/web that referenced this pull request Feb 18, 2022
* Patches to make module operational.
* Minor fix to Readonly Switch
* Fix to render to set change attribute.
* Totals recompute.

Fixes OCA#697
bizzappdev pushed a commit to bizzappdev/web that referenced this pull request Nov 5, 2022
* Patches to make module operational.
* Minor fix to Readonly Switch
* Fix to render to set change attribute.
* Totals recompute.

Fixes OCA#697
JoanSForgeFlow pushed a commit to ForgeFlow/web that referenced this pull request Nov 14, 2022
* Patches to make module operational.
* Minor fix to Readonly Switch
* Fix to render to set change attribute.
* Totals recompute.

Fixes OCA#697
tarteo pushed a commit to tarteo/web that referenced this pull request Feb 28, 2023
* Patches to make module operational.
* Minor fix to Readonly Switch
* Fix to render to set change attribute.
* Totals recompute.

Fixes OCA#697
PieterPaulussen pushed a commit to GumbysBE/web that referenced this pull request Apr 28, 2023
* Patches to make module operational.
* Minor fix to Readonly Switch
* Fix to render to set change attribute.
* Totals recompute.

Fixes OCA#697
dreispt pushed a commit to ursais/web that referenced this pull request Jan 21, 2024
* Patches to make module operational.
* Minor fix to Readonly Switch
* Fix to render to set change attribute.
* Totals recompute.

Fixes OCA#697
norlinhenrik pushed a commit to norlinhenrik/web that referenced this pull request Jan 28, 2024
* Patches to make module operational.
* Minor fix to Readonly Switch
* Fix to render to set change attribute.
* Totals recompute.

Fixes OCA#697
SodexisTeam pushed a commit to SodexisTeam/web that referenced this pull request Feb 29, 2024
* Patches to make module operational.
* Minor fix to Readonly Switch
* Fix to render to set change attribute.
* Totals recompute.

Fixes OCA#697
mohs8421 pushed a commit to mohs8421/oca-web that referenced this pull request Jun 18, 2024
* Patches to make module operational.
* Minor fix to Readonly Switch
* Fix to render to set change attribute.
* Totals recompute.

Fixes OCA#697
Borruso pushed a commit to Borruso/web that referenced this pull request Nov 26, 2024
* Patches to make module operational.
* Minor fix to Readonly Switch
* Fix to render to set change attribute.
* Totals recompute.

Fixes OCA#697
yankinmax pushed a commit to yankinmax/web that referenced this pull request Jan 7, 2025
* Patches to make module operational.
* Minor fix to Readonly Switch
* Fix to render to set change attribute.
* Totals recompute.

Fixes OCA#697
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants