-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] [10.0] 2d widget fixes #712
Conversation
Thanks for the patches. Maybe you can consider also the issue #697 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how easy it is to overlook stuff in reviews...
@pedrobaeza I actually don't use it with totals in my implementation. I don't think the totals render very well in version 10, but decided not to try and add this "enhancement", and I just did the fix to ensure correct recomputing. |
Thanks again, Richard, can you please make a last change that is modifying module version number for reflecting the evolution of the module? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I squash at merge? As the only way to try here on runbot is to merge the PR and rebuild runbots that use it, I will merge. I would like to have demo data inside the module, but that would require to add code that can't be avoided when no demo data. @hbrunn do you have any possible idea?
first I thought you mean something like this, but now I understand you mean adding something that causes a field/wizard/view exist with demo=1 so that we can check stuff in runbot simpler? Never tried this, but I had to detect runbot before, and maybe we can say import socket
import os
if socket.getfqdn().endswith('odoo-community.org'):
import my_demo_model in |
@hbrunn thanks for the suggestion, but I don't really like a lot that because that will mean that I can't try in other DB except OCA runbot. I will think in this in my spare time and see if there's other option. |
if you always want to add stuff in demo mode, using a hack like https://github.com/OCA/server-tools/pull/876/files#diff-ded7038d0dcfffc218c449b206263ebfR38 to get the current database's cursor, and then check if it has demo data enabled might work |
That's something I like more 😄 but as said, to be tried on my spare time, which is very little... |
* Patches to make module operational. * Minor fix to Readonly Switch * Fix to render to set change attribute. * Totals recompute. Fixes OCA#697
* Patches to make module operational. * Minor fix to Readonly Switch * Fix to render to set change attribute. * Totals recompute. Fixes OCA#697
* Patches to make module operational. * Minor fix to Readonly Switch * Fix to render to set change attribute. * Totals recompute. Fixes OCA#697
* Patches to make module operational. * Minor fix to Readonly Switch * Fix to render to set change attribute. * Totals recompute. Fixes OCA#697
* Patches to make module operational. * Minor fix to Readonly Switch * Fix to render to set change attribute. * Totals recompute. Fixes OCA#697
* Patches to make module operational. * Minor fix to Readonly Switch * Fix to render to set change attribute. * Totals recompute. Fixes OCA#697
* Patches to make module operational. * Minor fix to Readonly Switch * Fix to render to set change attribute. * Totals recompute. Fixes #697
* Patches to make module operational. * Minor fix to Readonly Switch * Fix to render to set change attribute. * Totals recompute. Fixes OCA#697
* Patches to make module operational. * Minor fix to Readonly Switch * Fix to render to set change attribute. * Totals recompute. Fixes OCA#697
* Patches to make module operational. * Minor fix to Readonly Switch * Fix to render to set change attribute. * Totals recompute. Fixes OCA#697
* Patches to make module operational. * Minor fix to Readonly Switch * Fix to render to set change attribute. * Totals recompute. Fixes OCA#697
* Patches to make module operational. * Minor fix to Readonly Switch * Fix to render to set change attribute. * Totals recompute. Fixes OCA#697
* Patches to make module operational. * Minor fix to Readonly Switch * Fix to render to set change attribute. * Totals recompute. Fixes OCA#697
* Patches to make module operational. * Minor fix to Readonly Switch * Fix to render to set change attribute. * Totals recompute. Fixes OCA#697
* Patches to make module operational. * Minor fix to Readonly Switch * Fix to render to set change attribute. * Totals recompute. Fixes OCA#697
* Patches to make module operational. * Minor fix to Readonly Switch * Fix to render to set change attribute. * Totals recompute. Fixes OCA#697
* Patches to make module operational. * Minor fix to Readonly Switch * Fix to render to set change attribute. * Totals recompute. Fixes OCA#697
* Patches to make module operational. * Minor fix to Readonly Switch * Fix to render to set change attribute. * Totals recompute. Fixes OCA#697
* Patches to make module operational. * Minor fix to Readonly Switch * Fix to render to set change attribute. * Totals recompute. Fixes OCA#697
* Patches to make module operational. * Minor fix to Readonly Switch * Fix to render to set change attribute. * Totals recompute. Fixes OCA#697
* Patches to make module operational. * Minor fix to Readonly Switch * Fix to render to set change attribute. * Totals recompute. Fixes OCA#697
* Patches to make module operational. * Minor fix to Readonly Switch * Fix to render to set change attribute. * Totals recompute. Fixes OCA#697
* Patches to make module operational. * Minor fix to Readonly Switch * Fix to render to set change attribute. * Totals recompute. Fixes OCA#697
* Patches to make module operational. * Minor fix to Readonly Switch * Fix to render to set change attribute. * Totals recompute. Fixes OCA#697
* Patches to make module operational. * Minor fix to Readonly Switch * Fix to render to set change attribute. * Totals recompute. Fixes OCA#697
Fixes display and input bugs in 2d widgets.