Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.0][IMP][web_responsive] Make search bar sticky #633

Merged
merged 6 commits into from
May 23, 2017
Merged

[10.0][IMP][web_responsive] Make search bar sticky #633

merged 6 commits into from
May 23, 2017

Conversation

tarteo
Copy link
Member

@tarteo tarteo commented May 19, 2017 •
edited
Loading

This PR makes the search bar (.o_control_panel) 'stick' to the secondary (top) menu bar (only on big screens).

Before:
image

After:
image

@pedrobaeza
Copy link
Member

Can you put some screenshots of before and after to visually check?

@tarteo
Copy link
Member Author

tarteo commented May 19, 2017

@pedrobaeza Yes! 👍

@pedrobaeza pedrobaeza requested review from yajo and lasley May 19, 2017 14:38
lasley
lasley approved these changes May 22, 2017
View reviewed changes
Copy link
Contributor

@lasley lasley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea @tarteo

yajo
yajo approved these changes May 23, 2017
View reviewed changes
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that sticking the top bar in phones does not allow the user to reach some menu entries, but it's not this PR's fault, so OK for me.

@yajo yajo merged commit 2b986c4 into OCA:10.0 May 23, 2017
angelmoya pushed a commit to PESOL/web that referenced this pull request Oct 6, 2017
@angelmoya
[10.0][IMP][web_responsive] Make search bar sticky (OCA#633)
526e82d 
* Initial commit

* Initial commit
yaniaular pushed a commit to vauxoo-dev/web that referenced this pull request May 14, 2018
[10.0][IMP][web_responsive] Make search bar sticky (OCA#633)
1479bc6 
* Initial commit

* Initial commit
yaniaular pushed a commit to vauxoo-dev/web that referenced this pull request May 14, 2018
[10.0][IMP][web_responsive] Make search bar sticky (OCA#633)
725b892 
* Initial commit

* Initial commit
yajo pushed a commit to Tecnativa/web that referenced this pull request Oct 5, 2018
@yajo
[10.0][IMP][web_responsive] Make search bar sticky (OCA#633)
cf17f09 
* Initial commit

* Initial commit
yajo pushed a commit to Tecnativa/web that referenced this pull request Dec 10, 2018
@yajo
[10.0][IMP][web_responsive] Make search bar sticky (OCA#633)
c0fdbbd 
* Initial commit

* Initial commit
tschanzt pushed a commit to camptocamp/web that referenced this pull request Jun 19, 2019
[10.0][IMP][web_responsive] Make search bar sticky (OCA#633)
93742c4 
* Initial commit

* Initial commit
Tardo pushed a commit to Tecnativa/web that referenced this pull request Sep 30, 2019
@Tardo
[10.0][IMP][web_responsive] Make search bar sticky (OCA#633)
94a01b1 
* Initial commit

* Initial commit
Tardo pushed a commit to Tecnativa/web that referenced this pull request Oct 13, 2019
@Tardo
[10.0][IMP][web_responsive] Make search bar sticky (OCA#633)
b3d4976 
* Initial commit

* Initial commit
@tarteo tarteo deleted the 100_imp_web_responsive_sticky_searchbar branch October 30, 2019 15:30
pierre-pizzetta pushed a commit to pierre-pizzetta/web that referenced this pull request Oct 17, 2020
@pierre-pizzetta
[10.0][IMP][web_responsive] Make search bar sticky (OCA#633)
3341db8 
* Initial commit

* Initial commit
SplashS pushed a commit to SplashS/web that referenced this pull request Feb 11, 2021
[10.0][IMP][web_responsive] Make search bar sticky (OCA#633)
fbbfe32 
* Initial commit

* Initial commit
SplashS pushed a commit to SplashS/web that referenced this pull request Mar 17, 2021
@SplashS
[10.0][IMP][web_responsive] Make search bar sticky (OCA#633)
03a7590 
* Initial commit

* Initial commit
SplashS pushed a commit to SplashS/web that referenced this pull request Oct 21, 2021
@SplashS
[10.0][IMP][web_responsive] Make search bar sticky (OCA#633)
6e4cc0c 
* Initial commit

* Initial commit
SplashS pushed a commit to SplashS/web that referenced this pull request Nov 15, 2021
@SplashS
[10.0][IMP][web_responsive] Make search bar sticky (OCA#633)
5aa73c7 
* Initial commit

* Initial commit
bvanjeelharia pushed a commit to bvanjeelharia/web that referenced this pull request Feb 6, 2023
@bvanjeelharia
[10.0][IMP][web_responsive] Make search bar sticky (OCA#633)
d199d85 
* Initial commit

* Initial commit
bvanjeelharia pushed a commit to bvanjeelharia/web that referenced this pull request Feb 6, 2023
@bvanjeelharia
[10.0][IMP][web_responsive] Make search bar sticky (OCA#633)
4145bce 
* Initial commit

* Initial commit
bvanjeelharia pushed a commit to bvanjeelharia/web that referenced this pull request Feb 7, 2023
@bvanjeelharia
[10.0][IMP][web_responsive] Make search bar sticky (OCA#633)
2139799 
* Initial commit

* Initial commit
bvanjeelharia pushed a commit to bvanjeelharia/web that referenced this pull request Mar 1, 2023
@bvanjeelharia
[10.0][IMP][web_responsive] Make search bar sticky (OCA#633)
56ffa63 
* Initial commit

* Initial commit
TesaLazarenko pushed a commit to TesaLazarenko/oca_web that referenced this pull request Nov 17, 2023
@TesaLazarenko
[10.0][IMP][web_responsive] Make search bar sticky (OCA#633)
84f330d 
* Initial commit

* Initial commit
davidtranhp pushed a commit to davidtranhp/web that referenced this pull request Feb 7, 2024
@bvanjeelharia
[10.0][IMP][web_responsive] Make search bar sticky (OCA#633)
014261e 
* Initial commit

* Initial commit
davidtranhp pushed a commit to davidtranhp/web that referenced this pull request Feb 7, 2024
@TesaLazarenko
[10.0][IMP][web_responsive] Make search bar sticky (OCA#633)
39128af 
* Initial commit

* Initial commit
kobros-tech pushed a commit to kobros-tech/web that referenced this pull request Dec 23, 2024
@kobros-tech
[10.0][IMP][web_responsive] Make search bar sticky (OCA#633)
79a1978 
* Initial commit

* Initial commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lasley lasley lasley approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@yajo yajo yajo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tarteo @pedrobaeza @yajo @lasley