[FIX][web_export_view] Remove monetary formatting #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monetary fields were being exported empty because the parsing failed. In the way of correctly exporting them as numbers, this chunk of code's performance has been improved.
|
@yajo I cannot test it, runbot see:
|
chienandalu
suggested changes
Mar 30, 2017
| // Always use a `.` as decimal separator | ||
| .replace(_t.database.parameters.decimal_point, ".") | ||
| // Remove non-numeric characters | ||
| .replace(/[^\d\.-]/g, ""); |
There was a problem hiding this comment.
There is semicolon here that avoids proper enclosure
pedrobaeza
approved these changes
Mar 31, 2017
JBF91
pushed a commit
to JBF91/web
that referenced
this pull request
Nov 14, 2017
Monetary fields were being exported empty because the parsing failed. In the way of correctly exporting them as numbers, this chunk of code's performance has been improved.
JBF91
pushed a commit
to JBF91/web
that referenced
this pull request
Nov 14, 2017
Monetary fields were being exported empty because the parsing failed. In the way of correctly exporting them as numbers, this chunk of code's performance has been improved.
mstuttgart
pushed a commit
to multidadosti-erp/web
that referenced
this pull request
Mar 15, 2018
Monetary fields were being exported empty because the parsing failed. In the way of correctly exporting them as numbers, this chunk of code's performance has been improved.
pedrobaeza
pushed a commit
to JBF91/web
that referenced
this pull request
Aug 15, 2018
Monetary fields were being exported empty because the parsing failed. In the way of correctly exporting them as numbers, this chunk of code's performance has been improved.
valtterilattu
pushed a commit
to valtterilattu/web
that referenced
this pull request
Apr 3, 2019
Monetary fields were being exported empty because the parsing failed. In the way of correctly exporting them as numbers, this chunk of code's performance has been improved.
ernestotejeda
pushed a commit
to Tecnativa/web
that referenced
this pull request
May 3, 2019
Monetary fields were being exported empty because the parsing failed. In the way of correctly exporting them as numbers, this chunk of code's performance has been improved.
tschanzt
pushed a commit
to camptocamp/web
that referenced
this pull request
Jun 19, 2019
Monetary fields were being exported empty because the parsing failed. In the way of correctly exporting them as numbers, this chunk of code's performance has been improved.
CarlosRoca13
pushed a commit
to Tecnativa/web
that referenced
this pull request
Nov 4, 2020
Monetary fields were being exported empty because the parsing failed. In the way of correctly exporting them as numbers, this chunk of code's performance has been improved.
vancouver29
pushed a commit
to elego/web
that referenced
this pull request
Aug 18, 2022
Monetary fields were being exported empty because the parsing failed. In the way of correctly exporting them as numbers, this chunk of code's performance has been improved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monetary fields were being exported empty because the parsing failed.
In the way of correctly exporting them as numbers, this chunk of code's performance has been improved.
This is a forward-port of #592.
@Tecnativa