[10.0] [MIG] help_online #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmignon
force-pushed
the
10.0-mig-help_online-lmi
branch
from
a52f7fd to
bcb43b7
Compare
lmignon
force-pushed
the
10.0-mig-help_online-lmi
branch
from
bcb43b7 to
49c738a
Compare
lasley
approved these changes
Jan 18, 2017
| @@ -1,5 +1,5 @@ | |||
| <?xml version='1.0' encoding='UTF-8' ?> | |||
| <openerp> | |||
| <odoo> | |||
There was a problem hiding this comment.
<odoo noupdate="1"> & can remove data tag
| @@ -1,5 +1,5 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <openerp> | |||
| <odoo> | |||
| <data> | |||
| <field name="context">{"search_default_website":1}</field> | ||
| </record> | ||
|
|
||
| <menuitem id="menu_help_main" name="Help Online" groups="help_online_group_writer"/> |
There was a problem hiding this comment.
It would be nice if the web icon was set to the application icon here something like this
ThomasBinsfeld
approved these changes
Mar 6, 2017
moylop260
approved these changes
Mar 6, 2017
|
@lmignon - This is approved, but lacking my non-blocking comments. Were you planning on attending to them before merge? |
|
@lasley Done |
Always use the '__export__' prefix when generating the xmlid of pages exported by the export wizard to avoid autmomatic removal of these pages by Odoo on system update (-u)
|
PLZ don't squash the commits on merge. |
|
Thanks @lmignon. Merged, no squash! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration of Help_online from 9.0.